Use datetime built-in library #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
- Structure in tests/files now follows a series of chronological test fixtures - Lay the groundwork for future Docker-based testing, where the package is containerised and scripted in bash to process all these fixtures - Rename some files to cut down the length - Adjust all tests accordingly - Moods file and the valid entry file are shared into multiple locations in the tests directory as symlinks - moved one check from test_default_moodverse_no_customisation to a separate test method
- Changed file access mode from `a` to `w`
- Classes and methods now accept local config as parameters instead of accessing them from a global variable. - Still needs work to do, especially in the actual user-facing command, but should get us closer to no globals.
DeutscheGabanna
force-pushed
the
db_cls_cls
branch
from
1d198a5
to
6a0406f
Compare
- BREAKING CHANGE: Remove custom Date and Time classes in favour of `datetime` built-in library - Add helper methods for the `datetime` library to help detect what format a date or time is written in (such solutions do not come out of the box) - Improved code structure - BREAKING CHANGE: Name changes to classes - more common use of `__getitem__` and `__setitem__` dunders instead of making separate methods for manipulating dictionary items - Remade tests to accommodate the library change
DeutscheGabanna
force-pushed
the
db_cls_cls
branch
from
6a0406f
to
1347eb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contents (#20)
IMPORTANT: There is 1 breaking change.
Other
Run all testsENTRYPOINT&CMDdatetimelibraryUpgrade instructions
💥 Use `datetime` library
Remove custom Date and Time classes in favour of
datetimebuilt-in librarydatetimelibrary to help detect what format a date or time is written in (such solutions do not come out of the box)__getitem__and__setitem__dunders instead of making separate methods for manipulating dictionary items