De-uppercase loadout names #10899
Merged
De-uppercase loadout names #10899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Applied to the Vendors sidebar as well: Before: After: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loadout names are not saved as uppercase, but they were displayed that way on the loadouts page because that's the default title style. This changes them back to being normal case, in both the sidebar and the loadout views themselves. I also increased the size of the loadout view titles a bit to make up for the lost visual weight.
This was attempted before, but I didn't like the result. That PR applied the de-uppercasing to all side menus (not just loadouts), did not restore the letter spacing, and did not remove the uppercasing from the loadout views.
Before:
After:
