Feature/vulnerable software fuzzy matching #1799
Conversation
-also lucene fuzzing ~ Signed-off-by: Drew Thompson <[email protected]>
Signed-off-by: Drew Thompson <[email protected]>
Signed-off-by: Drew Thompson <[email protected]>
Signed-off-by: Drew Thompson <[email protected]>
handle componentUpdate comparisons, fix test Signed-off-by: Drew Thompson <[email protected]>
Signed-off-by: Drew Thompson <[email protected]>
Signed-off-by: Drew Thompson <[email protected]>
Signed-off-by: Drew Thompson <[email protected]>
Signed-off-by: Drew Thompson <[email protected]>
Signed-off-by: Drew Thompson <[email protected]>
Signed-off-by: Drew Thompson <[email protected]>
There was a problem hiding this comment.
Aaaaaaand there's a merge conflict again. Terribly sorry, try rebasing this one with git pull --rebase so you're not running in DCO issues again.
We also have to remember making the new property available in the UI here: https://github.com/DependencyTrack/frontend/blob/master/src/views/administration/analyzers/InternalAnalyzer.vue#L5-L10. @officerNordberg, will you raise a PR for that or do you want us to do it?
Signed-off-by: Drew Thompson <[email protected]>
I would have done the rebase but I had other commits in my branch from merging master and rebase is a mess. I didn't trust it and the DCO recommendations seem to warn against it. Also the @#$@ github UI helpers are crap for DCO. I can't figure out if I need this https://chrome.google.com/webstore/detail/dco-github-ui/onhgmjhnaeipfgacbglaphlmllkpoijo/related or what the resolution to todogroup/gh-issues#50 was and how to resolve it but it further makes me hate DCO and not understand its value beyond matching two strings which are both email addresses provided by the committer so, what does that prove?
I didn't know these were being added to the UI, I guess I'd prefer someone else do it as I don't know vue and I barely got it running locally took me too long from the README to figure out npm run serve -- --port 8000 instead of npm run serve |
Signed-off-by: Drew Thompson <[email protected]>
|
@nscuro upon further review I can probably handle submitting that PR until I uncover some other footguns and beartraps |
|
@officerNordberg Cool, let me know if you run into any issues. This may be helpful regarding the port situation: https://github.com/DependencyTrack/dependency-track/blob/master/DEVELOPING.md#debugging-with-frontend Also, thanks for adding tests! |
No description provided.