Merge pull request #231 from DennisvHest/229-memory-increases-over-time

Fixed memory leak with playlist cover images
DennisvHest · Dec 22, 2024 · b771ce1 · b771ce1
2 parents 13e98f3 + e3802c1
commit b771ce1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 10 deletions.
diff --git a/MapMaven/MapMaven.csproj b/MapMaven/MapMaven.csproj
@@ -23,6 +23,7 @@
         <SupportedOSPlatformVersion Condition="$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) == 'windows'">10.0.17763.0</SupportedOSPlatformVersion>
         <TargetPlatformMinVersion Condition="$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) == 'windows'">10.0.17763.0</TargetPlatformMinVersion>
 		<WindowsSdkPackageVersion>10.0.26100.42</WindowsSdkPackageVersion>
+		<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
 
 		<WindowsPackageType>None</WindowsPackageType>
     </PropertyGroup>

diff --git a/MapMaven/Services/Playlists/PlaylistCoverService.cs b/MapMaven/Services/Playlists/PlaylistCoverService.cs
@@ -4,14 +4,12 @@
 using Microsoft.VisualStudio.Threading;
 using System.Reactive.Linq;
 using MapMaven.Extensions;
-using System.Diagnostics.CodeAnalysis;
-using System.Runtime.CompilerServices;
 
 namespace MapMaven.Services.Playlists
 {
     public class PlaylistCoverService
     {
-        private Dictionary<Playlist, AsyncLazy<string>> _cachedCoverImages = new(new CachedPlaylistEqualityComparer());
+        private Dictionary<Playlist, AsyncLazy<string>> _cachedCoverImages = new();
 
         public PlaylistCoverService(IMapService mapService, IPlaylistService playlistService, IBeatSaberDataService beatSaberDataService)
         {
@@ -81,11 +79,4 @@ public async Task<string> GetCoverImageAsync(Playlist playlist)
             return null;
         }
     }
-
-    public class CachedPlaylistEqualityComparer : IEqualityComparer<Playlist>
-    {
-        public bool Equals(Playlist x, Playlist y) => ReferenceEquals(x, y);
-
-        public int GetHashCode([DisallowNull] Playlist obj) => RuntimeHelpers.GetHashCode(obj);
-    }
 }