Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add download path option #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

gusye1234
Copy link

This pr involved slight UI modification to add a download path configure

@gusye1234
Copy link
Author

  • The main UI looks like below

Screen Shot 2022-11-03 at 14 53 14

  • Users may text the download path themselves or use the browser button to pick one directory.
  • A path validation will be conducted before downloading:

Screen Shot 2022-11-03 at 14 53 31

@gusye1234
Copy link
Author

Gentle ping @DenBeke

BTW, I have never coded swift or used XCode before. There probably are many other ways to implement this feature and I may choose the worst one😂. Hope you don't feel disturbed when reviewing this.

Signed-off-by: Jianbai Ye <[email protected]>
@DenBeke
Copy link
Owner

DenBeke commented Nov 5, 2022

Don't worry, I'm also not an experienced macOS programmer :)

I was thinking, wouldn't it make more sense to have a button (probably with just a cogs icon) that opens a preferences window where more settings could be grouped together in the future? That would also less clutter the main screen which I want to keep as simple as possible.
What do you think?

@DenBeke
Copy link
Owner

DenBeke commented Feb 1, 2023

@gusye1234 I tried your PR and it seems that if I try to run it two consecutive times, the field is not reappearing again. Could you fix that? Thanks

image

@DenBeke
Copy link
Owner

DenBeke commented Feb 1, 2023

My apologies for the delay in reviewing this, I have been quite busy.

@DenBeke DenBeke mentioned this pull request May 25, 2023
@gldtn
Copy link

gldtn commented Oct 11, 2023

Don't worry, I'm also not an experienced macOS programmer :)

I was thinking, wouldn't it make more sense to have a button (probably with just a cogs icon) that opens a preferences window where more settings could be grouped together in the future? That would also less clutter the main screen which I want to keep as simple as possible. What do you think?

Just a quick question, where you guys would recommend someone to start learning swift?

@DenBeke
Copy link
Owner

DenBeke commented Oct 12, 2023

Just a quick question, where you guys would recommend someone to start learning swift?

Long time ago I saw some live demos... So yeah, can't really help you with real resources, but Apple has quite a lot of information on their developer website: https://developer.apple.com/swift/resources/

Hope this helps...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants