-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add karpatkey #6690
feat: add karpatkey #6690
Conversation
The adapter at projects/karpatkey exports TVL:
|
hi @mariano-aguero, Sorry, I am waiting a bit for what rest of team members think, unlike other products where single protocol has control over the funds, when they are in gnosis wallets, it gets tricky. |
Hey @g1nt0ki! I understand the issue. Just in case, I wanted to clarify the way karpatkey manages funds. It's not that funds are simply held in a safe contract, but we deploy a contract (Zodiac's Roles Modifier module) through which the safe holding the funds grants fine-tuned granular permissions (developed here by karpatkey) to a karpatkey safe that executes transactions on behalf of the original safe. This is the principle by which our non-custodial asset management platform works, despite the funds not being deposited in a particular karpatkey contract. |
@sgzerbo sorry, we cant count it as tvl (for now), I think what you have created is cool and much needed infra, but counting it as tvl opens pandora's box imo (and rest of the team agrees). when multiple modules are linked to a single gnosis safe, to whom does the tvl belong (another PR with similar issue: #6097) This is a good metric, we will try to find a solution/workaround to show this but it will take some time :( |
@g1nt0ki I understand the rational :(... On the other hand I would urge you guys to find a way to show these metrics (we'll be patient :) ). Our assets under management with our infra currently amount to ~360M consisting of several DAO tresauries which represents a vote of confidence in our tech, and we only hope this number to increase. We'd be delighted to see this data reflected in defi-llama |
Hello @g1nt0ki, bumping this conversation, I would like to check with you and the team this: In karpatkey's solution, as mentioned in a previous comment, the Avatar (a 1 of 1 Gnosis Safe controlled by the DAO) grants permission to another Gnosis Safe (controlled by karpatkey) to act on its behalf on a strict list of operations (the preset list of actions). This transaction can be tracked on-chain, so it is possible to verify that the TVL is linked to karpatkey, even remaining non-custodial. If we provide, as a comment, in the adapter, the tx where that happens for each DAO address that karpatkey manages, would this ease the concerns about to whom the TVL belongs? For example, in our commit, this address from ENS DAO (0x4F2083f5fBede34C2714aFfb3105539775f7FE64), granted permissions to our address (0xb423e0f6E7430fa29500c5cC9bd83D28c8BD8978). As those funds are actively managed and invested/deposited in other protocols, it doesn't seem to be an issue to have the "double count" on it. Is this a valid angle, or do we need to think about something else? |
NOTE
package-lock.json
file as part of your changes, we use lockfileVersion 2, and most use v1 and using that messes up our CIName (to be shown on DefiLlama):
karpatkey
Twitter Link:
https://twitter.com/karpatkey
List of audit links if any:
Website Link:
https://www.karpatkey.com/
Logo (High resolution, will be shown with rounded borders):
Press kit if necessary https://drive.google.com/drive/u/1/folders/1-RaGdsneMJ1sznUkzBw2CCWlLlO_EAJB
Current TVL:
xdai: 13.13 M
ethereum: 104.93 M
total: 118.05 M
Treasury Addresses (if the protocol has treasury)
Chain:
Ethereum
Gnosis Chain (xdai)
Coingecko ID (so your TVL can appear on Coingecko, leave empty if not listed):
Coinmarketcap ID (so your TVL can appear on Coinmarketcap, leave empty if not listed):
Short Description (to be shown on DefiLlama):
We help DAOs to preserve capital through state-of-the-art risk management and trust-minimised DeFi treasury execution.
Token address and ticker if any:
Category (full list at https://defillama.com/categories) *Please choose only one:
7 - Services
Oracle used (Chainlink/Band/API3/TWAP or any other that you are using):
forkedFrom (Does your project originate from another project):
No
methodology (what is being counted as tvl, how is tvl being calculated):
karpatkey manages funds through its non-custodial platform by means of the Zodiac Roles Modifier module
Github org/user (Optional, if your code is open source, we can track activity):
https://github.com/KarpatkeyDAO