Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sablier updates #12815

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Sablier updates #12815

merged 2 commits into from
Dec 23, 2024

Conversation

PaulRBerg
Copy link
Contributor

Made a few changes to the Sablier adapters.

  • Renamed sablier-v2 to sablier-lockup
  • Renamed sablier to sablier-legacy

refactor: reorder keys alphabetically in sablier
refactor: rename "config" object to "contracts"
refactor: rename "sablier" to "sablier-legacy"
refactor: rename "sablier-v2" to "sablier-lockup"
@PaulRBerg
Copy link
Contributor Author

Can you please merge this PR at the same with DefiLlama/defillama-server#8909, to avoid any downtime?

Copy link
Member

@g1nt0ki g1nt0ki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is hard to tell, is there any logic change other than moving around code & renaming folders?

We will change the name, but renaming folders actually break our system

@g1nt0ki g1nt0ki self-assigned this Dec 22, 2024
@realdealshaman realdealshaman merged commit 3b195b0 into DefiLlama:main Dec 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants