-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch Protocol Updates - protocol keys renaming, missing protocols ad… #11772
Conversation
…ded, deprecated protocols removed.
The adapter at projects/kinetix-amm-v3 exports TVL:
|
The adapter at projects/metavault-amm-v2 exports TVL:
|
The adapter at projects/quickswap-hydra exports TVL:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Afraid I have reject this PR for two reasons:
-
Changing key breaks our server, it would look for the file which will be missing now. This is the reason, we reject folder renaming. If you want to change listing title, it can be done here: https://github.com/0xmDreamy/defillama-server/blob/fix/update-abracadabra-chains-and-oracles/defi/src/protocols/data.ts
-
We do not remove deprecated projects, again it will break our server, and if we delist, chain tvl history will be affected. What we do in these cases is, add hallmark to let users know that product is winding down.
Also, thanks for detailed breakdown, makes it much easier to review :) |
Okay thanks, it was a bit difficult to prepare this PR 😵💫 . What can we do for a better organization? We also added a new sub-protocols. Can you add those new protocols? |
@0xrmvdao yeah, sorry about this. I have added the new protocols now By better organization, you mean the folder names in this repo? |
Hi, as the core developer team (or part of the team) of the following projects, we want to make some batch updates in our projects. In this way, we want to make it easy to understand the projects both for you, for our customers and for us in the next maintenance processes.
Projects included in the update: Metavault, LineHub, Kinetix, SparkDEX, GrizzlyFi, Quickswap
Actions
Metavault
Parent Protocol: Metavault
LineHub
Parent Protocol: LineHub
Kinetix
Parent Protocol: Kinetix
SparkDEX
Parent Protocol: SparkDEX
GrizzlyFi
Parent Protocol: GrizzlyFi
Quickswap
Parent Protocol: Quickswap
PROJECT DASHBOARDS: We have prepared the following tables to represent the lists we would like to see in the Defillama Dashboards for the projects we develop or provide development support for.
Metavault on Defillama Dashboards
LineHub on Defillama Dashboards
Kinetix on Defillama Dashboards
SparkDEX on Defillama Dashboards
GrizzlyFi on Defillama Dashboards
Notes: We only provide development support to this project: GrizzlyFi Derivatives V2. Other projects are maintained by the core team. This change is only for GrizzlyFi Derivatives V2 protocol.
Quickswap on Defillama Dashboards
Notes: We only provide development support to these two projects: Quickswap Derivatives and Quickswap Hydra. Other projects are maintained by the core team. This change is only for Quickswap Derivatives and Quickswap Hydra protocols.