Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: venofinance tvl #11749

Closed
wants to merge 2 commits into from
Closed

Conversation

CronosLabsDev
Copy link
Contributor

Hello,

this PR will fix the following issues in the venofinance adapter:

  • TVL from YbEth/YbUsd will no longer be tracked, as these numbers are already tracked by getting them via the vETH and vUSD contracts respectively. So the reported TVL will be lower after merging this PR.
  • The zkCRO contract locks LCRO, so we report the underlying LCRO value instead of CRO now. zkCRO is the native token of the Cronos zkEVM chain. To get the required numbers, however, we have to make calls on the Cronos EVM and Ethereum chain (see code).

Thank you

NOTE

Please enable "Allow edits by maintainers" while putting up the PR.

@llamatester
Copy link

The adapter at projects/venofinance exports TVL:

cronos                    23.50 M
cronos_zkevm              20.78 M
cronos-staking            1.02 M
staking                   1.02 M
era                       130.86 k

total                    44.41 M 


return api.getBalances();
zkEvmApi.addCGToken('liquid-cro', totalLcro / 1e8);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deduping vETH and vUSD I sort of understand, but this part, no. The interaction happens in ethereum right? why is it counted in cronos zkevm?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand your concern. Please see the updated code. We read the zkCRO supply directly on the Cronos zkEVM chain now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, the issue remains, I didnt see any option for the users to interact with zk chain on the webpage

@g1nt0ki g1nt0ki self-assigned this Sep 26, 2024
@llamatester
Copy link

The adapter at projects/venofinance exports TVL:

cronos                    23.85 M
cronos_zkevm              20.69 M
cronos-staking            1.01 M
staking                   1.01 M
era                       130.79 k

total                    44.67 M 

@g1nt0ki g1nt0ki closed this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants