Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Incorrect token liquidity tracking and old social links for Morphex / BMX #11336

Closed
wants to merge 4 commits into from

Conversation

daedboi
Copy link
Contributor

@daedboi daedboi commented Aug 17, 2024

NOTE

Please enable "Allow edits by maintainers" while putting up the PR.


  • If you would like to add a volume adapter please submit the PR here.
  • If you would like to add a liquidations adapter, please refer to this readme document for details.
  1. Once your adapter has been merged, it takes time to show on the UI. If more than 24 hours have passed, please let us know in Discord.
  2. Sorry, We no longer accept fetch adapter for new projects, we prefer the tvl to computed from blockchain data, if you have trouble with creating a the adapter, please hop onto our discord, we are happy to assist you.
  3. Please fill the form below only if the PR is for listing a new protocol else it can be ignored/replaced with reason/details about the PR
  4. For updating listing info It is a different repo, you can find your listing in this file: https://github.com/DefiLlama/defillama-server/blob/master/defi/src/protocols/data2.ts, you can edit it there and put up a PR
  5. Do not edit/push package-lock.json file as part of your changes, we use lockfileVersion 2, and most use v1 and using that messes up our CI
  6. No need to go to our discord and announce that you've created a PR, we monitor all PRs and will review it asap

Name (to be shown on DefiLlama): https://defillama.com/protocol/bmx
Twitter Link: Please update our twitter link to https://x.com/MorphexBMX
List of audit links if any:
Website Link: https://www.bmx.trade/
Logo (High resolution, will be shown with rounded borders):
Current TVL:
Treasury Addresses (if the protocol has treasury): 0xE02Fb5C70aF32F80Aa7F9E8775FE7F12550348ec (Base)
Chain: Base, Mode
Coingecko ID (so your TVL can appear on Coingecko, leave empty if not listed): (https://api.coingecko.com/api/v3/coins/list)
Coinmarketcap ID (so your TVL can appear on Coinmarketcap, leave empty if not listed): (https://api.coinmarketcap.com/data-api/v3/map/all?listing_status=active,inactive,untracked&start=1&limit=10000)
Short Description (to be shown on DefiLlama):
Token address and ticker if any:
Category (full list at https://defillama.com/categories) *Please choose only one:
Oracle Provider(s): Specify the oracle(s) used (e.g., Chainlink, Band, API3, TWAP, etc.): Chainlink, Pyth, API3
Implementation Details: Briefly describe how the oracle is integrated into your project: Pricefeeds
Documentation/Proof: Provide links to documentation or any other resources that verify the oracle's usage: Chainlink and Pyth were previously submitted as oracles for BMX, there is no Chainlink on Mode so we went with API3. https://docs.morphex.trade/oracles
forkedFrom (Does your project originate from another project): We have 2 trading engines / UIs:
  • Classic: forked from GMX v1, our own custom interface
  • Freestyle: frontend for the SYMMIO intent-based trading engine
methodology (what is being counted as tvl, how is tvl being calculated):
Github org/user (Optional, if your code is open source, we can track activity):
Additional request: Currently, there are 4 different protocol versions lumped under "Morphex":
  • Morphex v1
  • Morphex v2
  • BMX
  • Freestyle

Morphex was our original deployment on Fantom and BNB Chain with the MPX token. BMX was deployed with a new token (BMX) due to tokenomics changes, and Freestyle is a product released under BMX. BMX is currently live on Base and Mode, with Optimism coming soon.

Would it be possible to separate Morphex and BMX as groupings, as it confuses our users too much with all of the differences between those protocols. It would be great to have something like this:

  1. "Morphex" grouping (Fantom and BNB Chain):
  • Morphex v1
  • Morphex v2
  1. "BMX" grouping (Base and Mode):
  • Classic
  • Freestyle

Classic is what we now call our GMX-v1 deployment (with spot+margin trading), Freestyle is intent-based. With the current grouping for everything (Morphex + BMX + Freestyle), the "BMX" tab is what would be the "Classic" tab. Just to reiterate, Classic and Freestyle should be under the grouping "BMX".

Additionally, I've submitted feedback directly through the site but it hasn't been fixed yet - the liquidity links for our token BMX are the wrong ones, they are showing for MPX on Fantom. Can this also please be fixed? https://www.coingecko.com/en/coins/bmx

image

image

@daedboi
Copy link
Contributor Author

daedboi commented Aug 17, 2024

Sorry for any potential confusion with the commits - with this PR there are no specific code changes I want to push.

@Define101
Copy link
Member

@daedboi this should be good now

@daedboi
Copy link
Contributor Author

daedboi commented Aug 20, 2024

@Define101 Thank you! I notice that our volume is still showing duplicated values from June 26, local tests return correct non-duplicated data from adapters - may you please look into this? ty!
image

@daedboi
Copy link
Contributor Author

daedboi commented Aug 20, 2024

Also, in the dimension-adapters repo, recently a PR was merged for updating our volume and revenue - for BMX Freestyle, the volume tab is missing, but I committed the volume adapter

@g1nt0ki g1nt0ki closed this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants