Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adapter, defi.money #11330

Merged
merged 7 commits into from
Aug 17, 2024
Merged

feat: Adapter, defi.money #11330

merged 7 commits into from
Aug 17, 2024

Conversation

0xpeluche
Copy link
Contributor

@0xpeluche 0xpeluche commented Aug 16, 2024


Name (to be shown on DefiLlama):

defi.money

Twitter Link:

https://x.com/defidotmoney

List of audit links if any:
Website Link:

https://defi.money/

Logo (High resolution, will be shown with rounded borders):
Current TVL:
Treasury Addresses (if the protocol has treasury)
Chain:

arbitrum, optimism

Coingecko ID (so your TVL can appear on Coingecko, leave empty if not listed): (https://api.coingecko.com/api/v3/coins/list)
Coinmarketcap ID (so your TVL can appear on Coinmarketcap, leave empty if not listed): (https://api.coinmarketcap.com/data-api/v3/map/all?listing_status=active,inactive,untracked&start=1&limit=10000)
Short Description (to be shown on DefiLlama):
Token address and ticker if any:
Category (full list at https://defillama.com/categories) *Please choose only one:

CDP & Yield (there is 2 different products split in 2 different folders)

Oracle Provider(s): Specify the oracle(s) used (e.g., Chainlink, Band, API3, TWAP, etc.):
Implementation Details: Briefly describe how the oracle is integrated into your project:
Documentation/Proof: Provide links to documentation or any other resources that verify the oracle's usage:
forkedFrom (Does your project originate from another project):
methodology (what is being counted as tvl, how is tvl being calculated):
Github org/user (Optional, if your code is open source, we can track activity):

@0xpeluche 0xpeluche self-assigned this Aug 16, 2024
@llamatester
Copy link

The adapter at projects/defi-money exports TVL:

optimism                  840.82 k
arbitrum                  781.63 k

total                    1.62 M 

@0xpeluche 0xpeluche changed the title feat: Adapter, defi.money [WIP] feat: Adapter, defi.money Aug 16, 2024
@llamatester
Copy link

The adapter at projects/defi-money exports TVL:

optimism                  896.50 k
arbitrum                  813.91 k

total                    1.71 M 

@0xpeluche 0xpeluche changed the title [WIP] feat: Adapter, defi.money feat: Adapter, defi.money Aug 16, 2024
@llamatester
Copy link

The adapter at projects/defi-money exports TVL:

optimism                  897.54 k
arbitrum                  814.75 k

total                    1.71 M 

@0xpeluche 0xpeluche changed the title feat: Adapter, defi.money [WIP] - feat: Adapter, defi.money Aug 16, 2024
@llamatester
Copy link

The adapter at projects/defi-money-cdp exports TVL:

optimism                  836.15 k
arbitrum                  777.78 k

total                    1.61 M 

@llamatester
Copy link

The adapter at projects/defi-money-earn exports TVL:

arbitrum                  975.75 k
optimism                  891.71 k

total                    1.87 M 

@0xpeluche 0xpeluche changed the title [WIP] - feat: Adapter, defi.money feat: Adapter, defi.money Aug 16, 2024
Object.keys(config).forEach((chain) => {
const { controller, viewer } = config[chain];
module.exports[chain] = {
methodology: "TVL corresponds to the collateral deposited in the markets",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we set the methodology at the top level, not per chain

I am not a fan of this pattern of splitting into micro functions as I have to read bottom up, feel like it is easier if everything is in a single function so one can read it like a script (just a suggestion)


const getLPTokens = async (api, stakingContracts) => {
const stakeTokens = await api.multiCall({
calls: stakingContracts.map((address) => ({ target: address })),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this wrapping is not needed

@llamatester
Copy link

The adapter at projects/defi-money-earn exports TVL:

arbitrum                  978.30 k
optimism                  894.23 k

total                    1.87 M 

@llamatester
Copy link

The adapter at projects/defi-money exports TVL:

pool2                     1.78 M
arbitrum-pool2            942.13 k
optimism                  850.80 k
optimism-pool2            834.24 k
arbitrum                  792.33 k

total                    1.64 M 

@llamatester
Copy link

The adapter at projects/defi-money exports TVL:

pool2                     1.78 M
arbitrum-pool2            942.13 k
optimism                  850.80 k
optimism-pool2            834.11 k
arbitrum                  792.33 k

total                    1.64 M 

@g1nt0ki g1nt0ki merged commit 4f69138 into DefiLlama:main Aug 17, 2024
1 check passed
0xIvan pushed a commit to 0xIvan/DefiLlama-Adapters that referenced this pull request Sep 11, 2024
* feat:Adapter, defi-money

* add methodology

* add yield part

* doublecounted: true

* split project in two different products

* code refactor

* remove pool2

---------

Co-authored-by: 0xpeluche <[email protected]>
Co-authored-by: g1nt0ki <[email protected]>
tlatkdgus1 pushed a commit to bifrost-platform/DefiLlama-Adapters that referenced this pull request Nov 25, 2024
* feat:Adapter, defi-money

* add methodology

* add yield part

* doublecounted: true

* split project in two different products

* code refactor

* remove pool2

---------

Co-authored-by: 0xpeluche <[email protected]>
Co-authored-by: g1nt0ki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants