Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blasterswap vaults #11029

Merged
merged 11 commits into from
Jul 19, 2024
Merged

Blasterswap vaults #11029

merged 11 commits into from
Jul 19, 2024

Conversation

lsblk07
Copy link
Contributor

@lsblk07 lsblk07 commented Jul 17, 2024

NOTE

Please enable "Allow edits by maintainers" while putting up the PR.


  • If you would like to add a volume adapter please submit the PR here.
  • If you would like to add a liquidations adapter, please refer to this readme document for details.
  1. Once your adapter has been merged, it takes time to show on the UI. If more than 24 hours have passed, please let us know in Discord.
  2. Sorry, We no longer accept fetch adapter for new projects, we prefer the tvl to computed from blockchain data, if you have trouble with creating a the adapter, please hop onto our discord, we are happy to assist you.
  3. Please fill the form below only if the PR is for listing a new protocol else it can be ignored/replaced with reason/details about the PR
  4. For updating listing info It is a different repo, you can find your listing in this file: https://github.com/DefiLlama/defillama-server/blob/master/defi/src/protocols/data2.ts, you can edit it there and put up a PR
  5. Do not edit/push package-lock.json file as part of your changes, we use lockfileVersion 2, and most use v1 and using that messes up our CI
  6. No need to go to our discord and announce that you've created a PR, we monitor all PRs and will review it asap

Name (to be shown on DefiLlama):
Twitter Link: https://x.com/BlasterSwap
List of audit links if any:
Website Link: https://blasterswap.com/
Logo (High resolution, will be shown with rounded borders): https://blasterswap.com/_next/static/media/blaster-logo.bcf14bda.svg
Current TVL: 7.4 mil
Treasury Addresses (if the protocol has treasury)
Chain: Blast
Coingecko ID (so your TVL can appear on Coingecko, leave empty if not listed): (https://api.coingecko.com/api/v3/coins/list)
Coinmarketcap ID (so your TVL can appear on Coinmarketcap, leave empty if not listed): (https://api.coinmarketcap.com/data-api/v3/map/all?listing_status=active,inactive,untracked&start=1&limit=10000)
Short Description (to be shown on DefiLlama): Blasterswap Vaults
Token address and ticker if any:
Category (full list at https://defillama.com/categories) *Please choose only one: DEFI
Oracle Provider(s): Specify the oracle(s) used (e.g., Chainlink, Band, API3, TWAP, etc.):
Implementation Details: Briefly describe how the oracle is integrated into your project:
Documentation/Proof: Provide links to documentation or any other resources that verify the oracle's usage:
forkedFrom (Does your project originate from another project):
methodology (what is being counted as tvl, how is tvl being calculated): tvl
Github org/user (Optional, if your code is open source, we can track activity):

@llamatester
Copy link

The adapter at projects/blasterswap-vaults exports TVL:

blast                     2.68 M

total                    2.68 M 

Copy link
Member

@g1nt0ki g1nt0ki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert to show it as staking

@lsblk07
Copy link
Contributor Author

lsblk07 commented Jul 17, 2024

please revert to show it as staking
But then the site displays it as 0 and users have to click the optional field. Isn't it allowed to leave it as tvl?

@lsblk07
Copy link
Contributor Author

lsblk07 commented Jul 17, 2024

@g1nt0ki I don't see how it's related to staking since users don't stake the project's token. They only stake Blast token (the native token of BLAST L2), Pacmoon and Andy for gold incentives on the blast chain

@g1nt0ki
Copy link
Member

g1nt0ki commented Jul 18, 2024

@lsblk07 end of the day it is still staking, similar protocol that I can think where we applied the same methodology is https://defillama.com/protocol/brewlabs#information

@g1nt0ki g1nt0ki self-assigned this Jul 18, 2024
@lsblk07
Copy link
Contributor Author

lsblk07 commented Jul 18, 2024

Hey @g1nt0ki! From the docs:

We separate TVL into different types. This lets users decide what they do and do not want to include in the dashboard data. These types are:

Staking - the platform's own tokens

The thing is that these tokens weren't launched by Blasterswap and according to your docs cannot be considered as staking. If we can't merge like this, I'll change the pr. Thanks!

@g1nt0ki
Copy link
Member

g1nt0ki commented Jul 18, 2024

@lsblk07 sorry, documentation needs to be updated, can you update the PR

@llamatester
Copy link

Error while running adapter at projects/blasterswap-vaults:

Error: Protocol doesn't have total tvl, make sure to export a tvl key either on the main object or in one of the chains
Truncated error stack:

    at /home/runner/work/DefiLlama-Adapters/DefiLlama-Adapters/test.js:198:11
Error saving cache: Error: ENOENT: no such file or directory, open '/home/runner/work/DefiLlama-Adapters/DefiLlama-Adapters/node_modules/@defillama/sdk/build/util/local_cache/zlib-1.0/BlockCache.json'
    at Object.openSync (node:fs:596:3)
    at Object.writeFileSync (node:fs:2322:35)
    at process.saveCache (/home/runner/work/DefiLlama-Adapters/DefiLlama-Adapters/node_modules/@defillama/sdk/build/util/cache.js:152:17)
    at process.emit (node:events:529:35)
    at process.exit (node:internal/process/per_thread:191:15)
    at process.handleError (/home/runner/work/DefiLlama-Adapters/DefiLlama-Adapters/utils/handleError.js:18:11)
    at process.emit (node:events:529:35)
    at emit (node:internal/process/promises:149:20)
    at processPromiseRejections (node:internal/process/promises:283:27)
    at process.processTicksAndRejections (node:internal/process/task_queues:96:32) {
  errno: -2,
  syscall: 'open',
  code: 'ENOENT',
  path: '/home/runner/work/DefiLlama-Adapters/DefiLlama-Adapters/node_modules/@defillama/sdk/build/util/local_cache/zlib-1.0/BlockCache.json'
}

@llamatester
Copy link

Error while running adapter at projects/blasterswap-vaults:

Error: Protocol doesn't have total tvl, make sure to export a tvl key either on the main object or in one of the chains
Truncated error stack:

    at /home/runner/work/DefiLlama-Adapters/DefiLlama-Adapters/test.js:198:11
Error saving cache: Error: ENOENT: no such file or directory, open '/home/runner/work/DefiLlama-Adapters/DefiLlama-Adapters/node_modules/@defillama/sdk/build/util/local_cache/zlib-1.0/BlockCache.json'
    at Object.openSync (node:fs:596:3)
    at Object.writeFileSync (node:fs:2322:35)
    at process.saveCache (/home/runner/work/DefiLlama-Adapters/DefiLlama-Adapters/node_modules/@defillama/sdk/build/util/cache.js:152:17)
    at process.emit (node:events:529:35)
    at process.exit (node:internal/process/per_thread:191:15)
    at process.handleError (/home/runner/work/DefiLlama-Adapters/DefiLlama-Adapters/utils/handleError.js:18:11)
    at process.emit (node:events:529:35)
    at emit (node:internal/process/promises:149:20)
    at processPromiseRejections (node:internal/process/promises:283:27)
    at process.processTicksAndRejections (node:internal/process/task_queues:96:32) {
  errno: -2,
  syscall: 'open',
  code: 'ENOENT',
  path: '/home/runner/work/DefiLlama-Adapters/DefiLlama-Adapters/node_modules/@defillama/sdk/build/util/local_cache/zlib-1.0/BlockCache.json'
}

@llamatester
Copy link

The adapter at projects/blasterswap-vaults exports TVL:

blast-staking             3.01 M
staking                   3.01 M
blast                     0

total                    0 

@lsblk07
Copy link
Contributor Author

lsblk07 commented Jul 18, 2024

Hi @g1nt0ki! Could you approve?

@g1nt0ki g1nt0ki merged commit c3c1476 into DefiLlama:main Jul 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants