Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added thala vethl tvl #10181

Merged
merged 2 commits into from
May 14, 2024
Merged

feat: added thala vethl tvl #10181

merged 2 commits into from
May 14, 2024

Conversation

LawsonGraham
Copy link
Contributor

@LawsonGraham LawsonGraham commented May 12, 2024

adding a new tvl metric for Thala - we track the amount of THL vested at some given timestamp, and add this up as the tvl of veTHL. This can be added directly into the Thala tab on UI!

NOTE

Please enable "Allow edits by maintainers" while putting up the PR.


  • If you would like to add a volume adapter please submit the PR here.
  • If you would like to add a liquidations adapter, please refer to this readme document for details.
  1. Once your adapter has been merged, it takes time to show on the UI. If more than 24 hours have passed, please let us know in Discord.
  2. Sorry, We no longer accept fetch adapter for new projects, we prefer the tvl to computed from blockchain data, if you have trouble with creating a the adapter, please hop onto our discord, we are happy to assist you.
  3. Please fill the form below only if the PR is for listing a new protocol else it can be ignored/replaced with reason/details about the PR
  4. For updating listing info It is a different repo, you can find your listing in this file: https://github.com/DefiLlama/defillama-server/blob/master/defi/src/protocols/data2.ts, you can edit it there and put up a PR
  5. Do not edit/push package-lock.json file as part of your changes, we use lockfileVersion 2, and most use v1 and using that messes up our CI
  6. No need to go to our discord and announce that you've created a PR, we monitor all PRs and will review it asap

Name (to be shown on DefiLlama):
Twitter Link:
List of audit links if any:
Website Link:
Logo (High resolution, will be shown with rounded borders):
Current TVL:
Treasury Addresses (if the protocol has treasury)
Chain:
Coingecko ID (so your TVL can appear on Coingecko, leave empty if not listed): (https://api.coingecko.com/api/v3/coins/list)
Coinmarketcap ID (so your TVL can appear on Coinmarketcap, leave empty if not listed): (https://api.coinmarketcap.com/data-api/v3/map/all?listing_status=active,inactive,untracked&start=1&limit=10000)
Short Description (to be shown on DefiLlama):
Token address and ticker if any:
Category (full list at https://defillama.com/categories) *Please choose only one:
Oracle Provider(s): Specify the oracle(s) used (e.g., Chainlink, Band, API3, TWAP, etc.):
Implementation Details: Briefly describe how the oracle is integrated into your project:
Documentation/Proof: Provide links to documentation or any other resources that verify the oracle's usage:
forkedFrom (Does your project originate from another project):
methodology (what is being counted as tvl, how is tvl being calculated):
Github org/user (Optional, if your code is open source, we can track activity):

@llamatester
Copy link

The adapter at projects/thala-vethl exports TVL:

aptos                     3.11 M

total                    3.11 M 

@g1nt0ki g1nt0ki self-assigned this May 13, 2024
Copy link
Member

@g1nt0ki g1nt0ki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @LawsonGraham thanks for the PR, but can update the code to compute the locked value on chain? also, this can be added under 'staking' to one of the existing thala adapters instead of a new section: https://docs.llama.fi/list-your-project/what-to-include-as-tvl

@0xl4ws
Copy link

0xl4ws commented May 14, 2024

hi @LawsonGraham thanks for the PR, but can update the code to compute the locked value on chain? also, this can be added under 'staking' to one of the existing thala adapters instead of a new section: https://docs.llama.fi/list-your-project/what-to-include-as-tvl

spoke with one of the mods in discord (ulysses and bentura), given how veTHL is stored, it is not easy to calculate on chain (the resource data on amount staked is stored at user accounts, not easy to track / fetch), and so we rely on indexer to get this data. They mentioned that this is ok.

For the staking section/organization: currently we create an adapter for different aspects of the protocol (move-dollar, thalaswap, thala-lsd)... so we don't have an umbrella 'adapter'. How should we proceed given this? It kind of applies to multiple of these different adapters so it doesn't make sense to add to one arbitrarily if that makes sense. lmk!

@0xl4ws
Copy link

0xl4ws commented May 14, 2024

hi @LawsonGraham thanks for the PR, but can update the code to compute the locked value on chain? also, this can be added under 'staking' to one of the existing thala adapters instead of a new section: https://docs.llama.fi/list-your-project/what-to-include-as-tvl

spoke with one of the mods in discord (ulysses and bentura), given how veTHL is stored, it is not easy to calculate on chain (the resource data on amount staked is stored at user accounts, not easy to track / fetch), and so we rely on indexer to get this data. They mentioned that this is ok.

For the staking section/organization: currently we create an adapter for different aspects of the protocol (move-dollar, thalaswap, thala-lsd)... so we don't have an umbrella 'adapter'. How should we proceed given this? It kind of applies to multiple of these different adapters so it doesn't make sense to add to one arbitrarily if that makes sense. lmk!

also, we can move it to the staking field of another adapter, but we would like to support timetravel for veTHL, however the other adapters don't support this... can this be configured to just the staking field? Or how is best to handle this

@g1nt0ki g1nt0ki merged commit 4c45d61 into DefiLlama:main May 14, 2024
1 check passed
@llamatester
Copy link

The adapter at projects/thala-vethl exports TVL:

aptos-staking             3.07 M
staking                   3.07 M
aptos                     0

total                    0 

@g1nt0ki
Copy link
Member

g1nt0ki commented May 14, 2024

both are good points, it will show up a new sub listing now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants