Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Checkmarx Cxflow SAST parser #9719

Open
wants to merge 25 commits into
base: dev
Choose a base branch
from
Open

Feature: Checkmarx Cxflow SAST parser #9719

wants to merge 25 commits into from

Conversation

biennd279
Copy link
Contributor

@biennd279 biennd279 commented Mar 11, 2024 •
edited
Loading

Description

CxFlow is a Spring Boot application that can run anywhere Java is installed. CxFlow glues together Checkmarx CxSAST and CxSCA scans with feedback to issue tracking systems via webhooks triggered by SCM events.
https://github.com/checkmarx-ltd/cx-flow/wiki

Cx-Flow is an official tool supported by Checkmarx Ltd. It is usually used to interact with CxSAST, CxSCA, and other systems like CMS and hook into the CICD pipeline.

This PR is used to support JSON reports for SAST generated by Cxflow.

Test results

I implement a unit test for 0,1 and many unit tests for cxflow sast results.

Documentation

I added a document about that supported type for this parser.

Checklist

This checklist is for your information.

  • Make sure to rebase your PR against the latest dev.
  • Features/Changes should be submitted against the dev.
  • Bugfixes should be submitted against the bugfix branch.
  • Give a meaningful name to your PR, as it may end up being used in the release notes.
  • Your code is flake8 compliant.
  • Your code is python 3.11 compliant.
  • If this is a new feature and not a bug fix, you've included the proper documentation in the docs at https://github.com/DefectDojo/django-DefectDojo/tree/dev/docs as part of this PR.
  • Model changes must include the necessary migrations in the dojo/db_migrations folder.
  • Add applicable tests to the unit tests.
  • Add the proper label to categorize your PR.

@biennd279 biennd279 marked this pull request as draft March 11, 2024 19:08
@biennd279 biennd279 changed the title Draft: Feature: checkmarx Cxflow SAST parser Feature: checkmarx Cxflow SAST parser Mar 11, 2024
@biennd279 biennd279 changed the title Feature: checkmarx Cxflow SAST parser Feature: Checkmarx Cxflow SAST parser Mar 11, 2024
@dryrunsecurity DryRunSecurity
Copy link

dryrunsecurity bot commented Mar 11, 2024 •
edited
Loading

Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.

DryRun Security Status Findings
Sensitive Functions Analyzer ✅ 0 findings
Configured Sensitive Files Analyzer ✅ 0 findings
Sensitive Files Analyzer ❕ 1 findings

Note

🟢 Risk threshold not exceeded.

Tip

Get answers to your security questions. Add a comment in this PR starting with @DryRunSecurity. For example...

@dryrunsecurity What are common security issues with web application cookies?

Powered by DryRun Security

@github-actions github-actions bot added settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR docs labels Mar 12, 2024
biennd4 and others added 8 commits March 12, 2024 11:58
draf parser
379de1e
fix typo
02f1dcc
@biennd279
draft parser path node
cf97328
add parser
a61b919
add dedup aglo
ea3f6d4
integration docs
ced3444
commented unused var
31c7403
Revert "Merge remote-tracking branch 'upstream/dev' into feature-chec…
f9cdafb 
…kmarx-cxflow-sast"

This reverts commit b167f2b5205b427ac0b26ae7fd3f6b4667a01cde, reversing
changes made to 5257a25204dbc9e6603b3b64bc1d78eddb824140.
@biennd279 biennd279 force-pushed the feature-checkmarx-cxflow-sast branch from b167f2b to f9cdafb Compare March 12, 2024 04:58
Revert "Revert "Merge remote-tracking branch 'upstream/dev' into feat…
7443312 
…ure-checkmarx-cxflow-sast""

This reverts commit f9cdafb.
@biennd279 biennd279 marked this pull request as ready for review March 12, 2024 05:42
@biennd279 biennd279 requested a review from Maffooch August 13, 2024 04:22
@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@biennd279
Copy link
Contributor Author

@manuel-sommer @Maffooch Should I make any changes to MR can merged?

@biennd279 biennd279 closed this Sep 2, 2024
@biennd279 biennd279 reopened this Sep 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@biennd279
Copy link
Contributor Author

@manuel-sommer @Maffooch I have just updated this MR. Can you review this MR?

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maffooch Maffooch Awaiting requested review from Maffooch

@manuel-sommer manuel-sommer Awaiting requested review from manuel-sommer

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
conflicts-detected docs parser settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR unittests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@biennd279 @manuel-sommer @Maffooch