Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Fortify: Support .fpr format #9590

Merged
merged 21 commits into from
Feb 28, 2024

Conversation

manuel-sommer
Copy link
Contributor

@manuel-sommer manuel-sommer commented Feb 20, 2024

see issue #9584

Copy link

dryrunsecurity bot commented Feb 20, 2024

Contextual Security Analysis

As DryRun Security performs checks, we’ll summarize them here. You can always dive into the detailed results in the section below for checks.

Status DryRun Security Check
Sensitive Functions Analyzer
Configured Sensitive Files Analyzer
Sensitive Files Analyzer

Chat with your AI-powered Security Buddy by typing @dryrunsecurity followed by your question into a comment.
Example: @dryrunsecurity What are common security issues with web application cookies?

Install and configure more repositories at DryRun Security

@github-actions github-actions bot added the docs label Feb 20, 2024
@manuel-sommer manuel-sommer marked this pull request as ready for review February 23, 2024 13:12
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link
Contributor

@schdief schdief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work, happy to see such a fast reaction time, added some comments for improvement

docs/content/en/integrations/parsers/file/fortify.md Outdated Show resolved Hide resolved
docs/content/en/integrations/parsers/file/fortify.md Outdated Show resolved Hide resolved
dojo/tools/fortify/parser.py Outdated Show resolved Hide resolved
dojo/tools/fortify/parser.py Show resolved Hide resolved
dojo/tools/fortify/parser.py Show resolved Hide resolved
unittests/tools/test_fortify_parser.py Show resolved Hide resolved
@manuel-sommer
Copy link
Contributor Author

Please review again @schdief

Copy link
Contributor

@schdief schdief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks again
as written, maybe we can enrich the test metadata too, to give more context about the scan, which is especially imprtant if there are no findings at all, to verify that the scan itself was valid (not just empty files scanned etc.)

what is the release cadence for defectdojo? when can we use this after merging?

@manuel-sommer
Copy link
Contributor Author

manuel-sommer commented Feb 26, 2024

what is the release cadence for defectdojo? when can we use this after merging?

https://documentation.defectdojo.com/contributing/branching-model/

@Maffooch Maffooch changed the title ✨ fpr format for fortify ✨ Fortify: Support .fpr format Feb 28, 2024
@Maffooch Maffooch merged commit 680e7ce into DefectDojo:dev Feb 28, 2024
121 of 122 checks passed
@manuel-sommer manuel-sommer deleted the advance_fortify_9584 branch February 28, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants