Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove filterwarnings for RemovedInDjango50Warning #9500

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Remove filterwarnings for RemovedInDjango50Warning #9500

merged 2 commits into from
Feb 28, 2024

Conversation

kiblik
Copy link
Contributor

@kiblik kiblik commented Feb 7, 2024

No description provided.

@github-actions github-actions bot added docker settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR docs unittests integration_tests parser conflicts-detected labels Feb 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@kiblik kiblik force-pushed the fix_filterwarnings_RemovedInDjango50Warning branch from 5c47289 to e7eebcd Compare February 7, 2024 15:54
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@dryrunsecurity DryRunSecurity
Copy link

dryrunsecurity bot commented Feb 7, 2024 •
edited
Loading

Contextual Security Analysis

As DryRun Security performs checks, we’ll summarize them here. You can always dive into the detailed results in the section below for checks.

Status DryRun Security Check
✅ Sensitive Functions Analyzer
✅ Configured Sensitive Files Analyzer
✅ Sensitive Files Analyzer

Chat with your AI-powered Security Buddy by typing @dryrunsecurity followed by your question into a comment.
Example: @dryrunsecurity What are common security issues with web application cookies?

Install and configure more repositories at DryRun Security

@kiblik kiblik marked this pull request as ready for review February 7, 2024 16:09
@kiblik kiblik marked this pull request as draft February 7, 2024 16:09
@kiblik kiblik closed this Feb 7, 2024
@kiblik kiblik reopened this Feb 7, 2024
@kiblik kiblik marked this pull request as ready for review February 7, 2024 17:01
@kiblik kiblik marked this pull request as draft February 7, 2024 19:09
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@kiblik kiblik force-pushed the fix_filterwarnings_RemovedInDjango50Warning branch from 0692999 to 74d07f9 Compare February 16, 2024 06:55
@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@kiblik kiblik closed this Feb 16, 2024
@kiblik kiblik reopened this Feb 16, 2024
@kiblik kiblik marked this pull request as ready for review February 16, 2024 08:05
This was referenced Feb 16, 2024
Merged
Merged
mtesauro
mtesauro approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@kiblik kiblik force-pushed the fix_filterwarnings_RemovedInDjango50Warning branch from 74d07f9 to 82b9475 Compare February 26, 2024 19:46
@kiblik kiblik force-pushed the fix_filterwarnings_RemovedInDjango50Warning branch from 82b9475 to 2abe22e Compare February 26, 2024 20:57
@kiblik
Copy link
Contributor Author

kiblik commented Feb 27, 2024

@grendel513, can I ask for approval and merge, please?

@mtesauro
Copy link
Contributor

@kiblik was about to merge then looked at the conflicts. Pretty sure I know how to resolve them but figured I'd give you a chance since this is your PR 😃

@kiblik kiblik force-pushed the fix_filterwarnings_RemovedInDjango50Warning branch from 2abe22e to 9496f0c Compare February 27, 2024 23:02
@kiblik
Copy link
Contributor Author

kiblik commented Feb 28, 2024

It is ready

@kiblik
Copy link
Contributor Author

kiblik commented Feb 28, 2024

This PR removes also warnings.filterwarnings("ignore", message="unclosed file .+").
It accidentally popped up back but removal was already accepted in #9498

@mtesauro mtesauro merged commit 3b5c056 into DefectDojo:dev Feb 28, 2024
122 checks passed
@kiblik kiblik deleted the fix_filterwarnings_RemovedInDjango50Warning branch February 28, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maffooch Maffooch Maffooch approved these changes

@mtesauro mtesauro mtesauro approved these changes

@cneill cneill cneill approved these changes

@grendel513 grendel513 grendel513 approved these changes

Assignees
No one assigned
Labels
settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kiblik @mtesauro @grendel513 @cneill @Maffooch