Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ merge veracode #9468

Closed
wants to merge 8 commits into from
Closed

Conversation

manuel-sommer
Copy link
Contributor

merge veracode source clear with veracode

@github-actions github-actions bot added New Migration Adding a new migration file. Take care when merging. docs unittests parser labels Feb 2, 2024
Copy link

dryrunsecurity bot commented Feb 2, 2024

Contextual Security Analysis

As DryRun Security performs checks, we’ll summarize them here. You can always dive into the detailed results in the section below for checks.

Status DryRun Security Check
Sensitive Functions Analyzer
Configured Sensitive Files Analyzer
Sensitive Files Analyzer

Chat with your AI-powered Security Buddy by typing @dryrunsecurity followed by your question into a comment.
Example: @dryrunsecurity What are common security issues with web application cookies?

Install and configure more repositories at DryRun Security

@manuel-sommer
Copy link
Contributor Author

@Maffooch, the unittests with "fixtures = ['dojo_testdata.json']" fail because dojo_testdata.json contains Veracode Scan, but I don't know the real cause why it fails. What do I have to do to fix the unittests?

@Maffooch
Copy link
Contributor

Maffooch commented Feb 6, 2024

I think the failing tests could be related to the creation of the Veracode Scan test type in the migration

Also curious about the Veracode SourceClear Scan that is being referenced in the migration, but not anywhere else in the code

@manuel-sommer
Copy link
Contributor Author

I think the failing tests could be related to the creation of the Veracode Scan test type in the migration

Then, I will just fix the failing tests.

Also curious about the Veracode SourceClear Scan that is being referenced in the migration, but not anywhere else in the code

The Veracode Source Clear Scan is in the migration as the exisiting Veracode Source Clear Scan parser is migrated to Veracode Scan to have one parser for the vendor Veracode with multiple scanners. This is also what I have done in the past with e.g. OpenVAS CSV and OpenVAS XML or Clair Klar Scan and Clair Scan

@manuel-sommer
Copy link
Contributor Author

@Maffooch or @kiblik, could you please help here? I am completely stuck on how to resolve the unittest problem here.

@Maffooch
Copy link
Contributor

@manuel-sommer I do not see anything glaringly obvious here. I can try to make some in the future to pull this down and just play around with it, but I cannot make strong commitment to that

@manuel-sommer manuel-sommer marked this pull request as draft February 27, 2024 12:04
@manuel-sommer
Copy link
Contributor Author

Shall I close this PR @mtesauro because of #9690 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs New Migration Adding a new migration file. Take care when merging. parser unittests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants