Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Implement Chef InSpec Parser #9329

Merged
merged 4 commits into from
Jan 19, 2024
Merged

✨ Implement Chef InSpec Parser #9329

merged 4 commits into from
Jan 19, 2024

Conversation

manuel-sommer
Copy link
Contributor

see issue #6990

@dryrunsecurity DryRunSecurity
Copy link

dryrunsecurity bot commented Jan 15, 2024 •
edited
Loading

Contextual Security Analysis

As DryRun Security performs checks, we’ll summarize them here. You can always dive into the detailed results in the section below for checks.

Status DryRun Security Check
✅ AI-powered Sensitive Function Check
✅ Configured Sensitive Files Check
✅ AI-powered Sensitive Files Check

Chat with your AI-powered Security Buddy by typing @dryrunsecurity followed by your question into a comment.
Example: @dryrunsecurity What are common security issues with web application cookies?

Install and configure more repositories at DryRun Security

mtesauro
mtesauro approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

cneill
cneill requested changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@cneill cneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple notes on this one...

dojo/tools/chefinspect/parser.py Show resolved Hide resolved
dojo/tools/chefinspect/parser.py Outdated Show resolved Hide resolved
@manuel-sommer manuel-sommer requested a review from cneill January 16, 2024 19:32
@manuel-sommer
Copy link
Contributor Author

Thank you for the review @cneill. I fixed your issues.

cneill
cneill approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@cneill cneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Approved

@Maffooch Maffooch changed the title ✨ implement chefinspect, #6990 ✨ Implement Chef InSpec Parser Jan 17, 2024
Maffooch
Maffooch previously approved these changes Jan 17, 2024
View reviewed changes
@Maffooch Maffooch dismissed their stale review January 17, 2024 16:55

Approved too quickly

@manuel-sommer
Copy link
Contributor Author

I can't see your comment @Maffooch that you approve this.

Maffooch
Maffooch requested changes Jan 17, 2024
View reviewed changes
dojo/tools/chefinspect/parser.py Outdated Show resolved Hide resolved
@manuel-sommer
Copy link
Contributor Author

Done

@mtesauro mtesauro merged commit 67f0e96 into DefectDojo:dev Jan 19, 2024
121 checks passed
@manuel-sommer manuel-sommer deleted the implement_chefinspect branch January 19, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cneill cneill cneill approved these changes

@Maffooch Maffooch Maffooch approved these changes

@mtesauro mtesauro mtesauro approved these changes

@grendel513 grendel513 grendel513 approved these changes

Assignees
No one assigned
Labels
docs parser unittests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@manuel-sommer @grendel513 @cneill @mtesauro @Maffooch