Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shellcheck #9147

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Fix shellcheck #9147

merged 2 commits into from
Jan 19, 2024

Conversation

kiblik
Copy link
Contributor

@kiblik kiblik commented Dec 11, 2023

Fix for #9119 (comment)

@dryrunsecurity DryRunSecurity
Copy link

dryrunsecurity bot commented Dec 11, 2023 •
edited
Loading

Contextual Security Analysis

As DryRun Security performs checks, we’ll summarize them here. You can always dive into the detailed results in the section below for checks.

Status DryRun Security Check
✅ AI-powered Sensitive Function Check
❌ Configured Sensitive Files Check
✅ AI-powered Sensitive Files Check

Chat with your AI-powered Security Buddy by typing @dryrunsecurity followed by your question into a comment.
Example: @dryrunsecurity What are common security issues with web application cookies?

Install and configure more repositories at DryRun Security

@kiblik kiblik marked this pull request as draft December 11, 2023 23:25
@kiblik
Copy link
Contributor Author

kiblik commented Dec 11, 2023

shellcheck is maybe fixed but opened couple of issues now

@kiblik kiblik mentioned this pull request Dec 31, 2023
Merged
@kiblik kiblik force-pushed the fix_koalaman_shellcheck branch from b9f6aa8 to 95e053a Compare January 11, 2024 16:34
@github-actions github-actions bot added New Migration Adding a new migration file. Take care when merging. settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR apiv2 docs unittests ui parser helm labels Jan 11, 2024
@kiblik kiblik force-pushed the fix_koalaman_shellcheck branch from 95e053a to 8ee6ad7 Compare January 11, 2024 16:37
@kiblik kiblik force-pushed the fix_koalaman_shellcheck branch from 8ee6ad7 to 3bbe6f3 Compare January 11, 2024 17:32
@kiblik kiblik marked this pull request as ready for review January 11, 2024 21:00
cneill
cneill reviewed Jan 12, 2024
View reviewed changes
Copy link
Contributor

@cneill cneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, but otherwise looks good. Thank you for tackling this! I should've done so when I first added the shellcheck job 😅

docker/entrypoint-unit-tests-devDocker.sh Outdated Show resolved Hide resolved
cneill
cneill approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@cneill cneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

mtesauro
mtesauro approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@mtesauro mtesauro merged commit 0444256 into DefectDojo:bugfix Jan 19, 2024
120 of 121 checks passed
@kiblik kiblik deleted the fix_koalaman_shellcheck branch January 19, 2024 08:34
@kiblik kiblik mentioned this pull request Jul 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maffooch Maffooch Maffooch approved these changes

@mtesauro mtesauro mtesauro approved these changes

@cneill cneill cneill approved these changes

@grendel513 grendel513 grendel513 approved these changes

Assignees
No one assigned
Labels
apiv2 docker docs helm integration_tests New Migration Adding a new migration file. Take care when merging. parser settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR ui unittests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kiblik @grendel513 @cneill @mtesauro @Maffooch