Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add unittest for .read() and utf-8 #9024 #9026

Merged
merged 5 commits into from
Dec 12, 2023
Merged

add unittest for .read() and utf-8 #9024 #9026

merged 5 commits into from
Dec 12, 2023

Conversation

manuel-sommer
Copy link
Contributor

unittest to catch errors described in #9024 and #9017

@manuel-sommer
Copy link
Contributor Author

This will fail at least for bundler

@manuel-sommer manuel-sommer mentioned this pull request Nov 19, 2023
Merged
@manuel-sommer
Copy link
Contributor Author

This is a first draft. Could you write your thoughts on this @kiblik ?

@manuel-sommer
Copy link
Contributor Author

Waiting for the merge of:
#9018
#9025
Then, I will rebase

kiblik
kiblik reviewed Nov 23, 2023
View reviewed changes
unittests/test_parsers.py Outdated Show resolved Hide resolved
unittests/test_parsers.py Outdated Show resolved Hide resolved
unittests/test_parsers.py Outdated Show resolved Hide resolved
unittests/test_parsers.py Outdated Show resolved Hide resolved
unittests/test_parsers.py Outdated Show resolved Hide resolved
@dryrunsecurity DryRunSecurity
Copy link

dryrunsecurity bot commented Nov 24, 2023 •
edited
Loading

Contextual Security Analysis

As DryRun Security performs checks, we’ll summarize them here. You can always dive into the results in the section below for checks.

Status DryRun Security Check
✅ Configured Sensitive Files Check
✅ AI-powered Sensitive Files Check

Chat with your AI-powered Security Buddy by typing /dryrunsec: (or /drs:) followed by your question. Example: /dryrunsec: From a security perspective, what are some sensitive files in an Express application?

Install and configure more repositories at DryRun Security

@kiblik
Copy link
Contributor

kiblik commented Nov 24, 2023

@manuel-sommer, tried this and read of file works for me manuel-sommer#1

@manuel-sommer
Copy link
Contributor Author

Lol, I don't know why it failed. :-D Now it works. Thank you @kiblik

@manuel-sommer manuel-sommer force-pushed the add_unittest_for_read_utf8 branch from 3f5d24a to a83dcbb Compare November 28, 2023 07:18
@manuel-sommer
Copy link
Contributor Author

This unittest proves that it would have caught #9018 and #9025

@manuel-sommer
Copy link
Contributor Author

Ready to review @cneill @Maffooch @mtesauro @blakeaowens

mtesauro
mtesauro approved these changes Dec 2, 2023
View reviewed changes
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

@Maffooch Maffooch merged commit 64a3b25 into DefectDojo:dev Dec 12, 2023
118 checks passed
@manuel-sommer manuel-sommer deleted the add_unittest_for_read_utf8 branch December 13, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiblik kiblik kiblik left review comments

@blakeaowens blakeaowens blakeaowens approved these changes

@mtesauro mtesauro mtesauro approved these changes

@cneill cneill cneill approved these changes

@grendel513 grendel513 grendel513 approved these changes

Assignees
No one assigned
Labels
parser unittests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@manuel-sommer @kiblik @grendel513 @cneill @mtesauro @blakeaowens @Maffooch