Feature/parser jfrog xray binary scan #9015

renejal · 2023-11-16T22:57:43Z

I will create a new pull request from number #8852 because it had commits that shouldn't be there

From our organization we want to contribute with a new xray parser for https://jfrog.com/help/r/jfrog-cli/on-demand-binary-scan

…b.com/bancolombia/django-DefectDojo into feature/parser_jfrog_xray_binary_scan

mtesauro · 2023-11-16T23:23:10Z

@renejal So close. Just a minor Flake8 to fix.

Thanks for removing those couple of unrelated files from the previous PR 👍

mtesauro

Approved

dojo/tools/jfrog_xray_on_demand_binary_scan/parser.py

cneill

Just a few suggestions around capitalization here.

docs/content/en/integrations/parsers/file/jfrog_xray_on_demand_binary_scan.md

dojo/settings/settings.dist.py

dojo/tools/jfrog_xray_on_demand_binary_scan/parser.py

kiblik

I wanted to provide my feedback sooner. Unfortunately, we had different internal priorities.

I really like this PR. But I provided a couple of my comments and suggestions.

I could image even more unittests for multiple fields. @renejal, if you would merge my PR bancolombia#80, I'm willing to add them by myself.

dojo/fixtures/defect_dojo_sample_data.json

docs/content/en/integrations/parsers/file/jfrog_xray_on_demand_binary_scan.md

dojo/tools/jfrog_xray_on_demand_binary_scan/parser.py

…_binary_scan.md Co-authored-by: Charles Neill <[email protected]>

Co-authored-by: Charles Neill <[email protected]>

…nctions

Co-authored-by: Charles Neill <[email protected]>

Co-authored-by: kiblik <[email protected]>

dryrunsecurity · 2023-11-21T13:10:07Z

Contextual Security Analysis

As DryRun Security performs checks, we’ll summarize them here. You can always dive into the results in the section below for checks.

Status	DryRun Security Check
✅	Configured Sensitive Files Check
✅	AI-powered Sensitive Files Check

Chat with your AI-powered Security Buddy by typing /dryrunsec: (or /drs:) followed by your question. Example: /dryrunsec: From a security perspective, what are some sensitive files in an Express application?

Install and configure more repositories at DryRun Security

Co-authored-by: kiblik <[email protected]>

…tests

JFrog mprovements

kiblik · 2023-11-22T23:03:57Z

@renejal, now it is ready bancolombia#82 :)

Xray on demand: Last Improvements and tests

* new parser Jfrog Xray on Demand Binary Scan * new parser Jfrog Xray on Demand Binary Scan * delete blank line at end of file * rename function * More sample reports * Update docs/content/en/integrations/parsers/file/jfrog_xray_on_demand_binary_scan.md Co-authored-by: Charles Neill <[email protected]> * Update docs/content/en/integrations/parsers/file/jfrog_xray_on_demand_binary_scan.md Co-authored-by: Charles Neill <[email protected]> * Update docs/content/en/integrations/parsers/file/jfrog_xray_on_demand_binary_scan.md Co-authored-by: Charles Neill <[email protected]> * Update dojo/settings/settings.dist.py Co-authored-by: Charles Neill <[email protected]> * Update dojo/settings/settings.dist.py Co-authored-by: Charles Neill <[email protected]> * Update dojo/tools/jfrog_xray_on_demand_binary_scan/parser.py Co-authored-by: Charles Neill <[email protected]> * Update dojo/tools/jfrog_xray_on_demand_binary_scan/parser.py Co-authored-by: Charles Neill <[email protected]> * Update dojo/tools/jfrog_xray_on_demand_binary_scan/parser.py Co-authored-by: Charles Neill <[email protected]> * Update dojo/tools/jfrog_xray_on_demand_binary_scan/parser.py Co-authored-by: Charles Neill <[email protected]> * Update dojo/tools/jfrog_xray_on_demand_binary_scan/parser.py Co-authored-by: Charles Neill <[email protected]> * Update dojo/tools/jfrog_xray_on_demand_binary_scan/parser.py Co-authored-by: kiblik <[email protected]> * Update dojo/tools/jfrog_xray_on_demand_binary_scan/parser.py Co-authored-by: kiblik <[email protected]> * First round of Improvements * Drop duplicates in component_id and full_path * Process per component * Visual improvements * Use+clean summary in Title, fix dedup, parse version, drop useless functions * Update dojo/tools/jfrog_xray_on_demand_binary_scan/parser.py Co-authored-by: Charles Neill <[email protected]> * Update dojo/tools/jfrog_xray_on_demand_binary_scan/parser.py Co-authored-by: kiblik <[email protected]> * Update dojo/tools/jfrog_xray_on_demand_binary_scan/parser.py Co-authored-by: kiblik <[email protected]> * Update dojo/tools/jfrog_xray_on_demand_binary_scan/parser.py Co-authored-by: kiblik <[email protected]> * Update dojo/tools/jfrog_xray_on_demand_binary_scan/parser.py Co-authored-by: kiblik <[email protected]> * Update dojo/tools/jfrog_xray_on_demand_binary_scan/parser.py Co-authored-by: kiblik <[email protected]> * fix test rename class * Last Improvements and tests * capitalization skills --------- Co-authored-by: Tomas Kubla <[email protected]> Co-authored-by: Charles Neill <[email protected]> Co-authored-by: kiblik <[email protected]>

* Created _init_.py * Created parser.py * Update README.md (#9048) * Fixing README links and formatting (#9022) * fixing up some links/etc * formatting * more formatting, links, etc * formatting table HTML * Fixing links * typo * formatting, links * typo; adding Aaron Weaver to hall of fame * reorganizing * Bump python-gitlab from 3.15.0 to 4.2.0 (#9064) Bumps [python-gitlab](https://github.com/python-gitlab/python-gitlab) from 3.15.0 to 4.2.0. - [Release notes](https://github.com/python-gitlab/python-gitlab/releases) - [Changelog](https://github.com/python-gitlab/python-gitlab/blob/main/CHANGELOG.md) - [Commits](python-gitlab/python-gitlab@v3.15.0...v4.2.0) --- updated-dependencies: - dependency-name: python-gitlab dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump fontawesomefree from 6.4.2 to 6.5.0 (#9074) Bumps [fontawesomefree](https://github.com/FortAwesome/Font-Awesome) from 6.4.2 to 6.5.0. - [Release notes](https://github.com/FortAwesome/Font-Awesome/releases) - [Changelog](https://github.com/FortAwesome/Font-Awesome/blob/6.x/CHANGELOG.md) - [Commits](FortAwesome/Font-Awesome@6.4.2...6.5.0) --- updated-dependencies: - dependency-name: fontawesomefree dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * 🎉 added humble #8988 (#8989) * 🎉 added humble * fixed humble * added endpoints * fix according to comment * fix according to review * update * added deduplication setting * fix * Bump social-auth-core from 4.5.0 to 4.5.1 (#9073) Bumps [social-auth-core](https://github.com/python-social-auth/social-core) from 4.5.0 to 4.5.1. - [Release notes](https://github.com/python-social-auth/social-core/releases) - [Changelog](https://github.com/python-social-auth/social-core/blob/master/CHANGELOG.md) - [Commits](python-social-auth/social-core@4.5.0...4.5.1) --- updated-dependencies: - dependency-name: social-auth-core dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Adding subcomponent labels for celery beat and worker (#9078) * Update rabbitmq Docker tag from 3.12.9 to v3.12.10 (docker-compose.yml) (#9075) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update postgres:16.1-alpine Docker digest from 16.1 to 16.1-alpine (docker-compose.yml) (#9082) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update redis:7.2.3-alpine Docker digest from 7.2.3 to 7.2.3-alpine (docker-compose.yml) (#9083) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Bump boto3 from 1.29.7 to 1.33.5 (#9085) Bumps [boto3](https://github.com/boto/boto3) from 1.29.7 to 1.33.5. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.29.7...1.33.5) --- updated-dependencies: - dependency-name: boto3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump fontawesomefree from 6.5.0 to 6.5.1 (#9086) Bumps [fontawesomefree](https://github.com/FortAwesome/Font-Awesome) from 6.5.0 to 6.5.1. - [Release notes](https://github.com/FortAwesome/Font-Awesome/releases) - [Changelog](https://github.com/FortAwesome/Font-Awesome/blob/6.x/CHANGELOG.md) - [Commits](FortAwesome/Font-Awesome@6.5.0...6.5.1) --- updated-dependencies: - dependency-name: fontawesomefree dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add logging statement for failed password reset validation logic (#9087) * Finding Template: Correct save ordering (#9088) * Feature/parser jfrog xray binary scan (#9015) * new parser Jfrog Xray on Demand Binary Scan * new parser Jfrog Xray on Demand Binary Scan * delete blank line at end of file * rename function * More sample reports * Update docs/content/en/integrations/parsers/file/jfrog_xray_on_demand_binary_scan.md Co-authored-by: Charles Neill <[email protected]> * Update docs/content/en/integrations/parsers/file/jfrog_xray_on_demand_binary_scan.md Co-authored-by: Charles Neill <[email protected]> * Update docs/content/en/integrations/parsers/file/jfrog_xray_on_demand_binary_scan.md Co-authored-by: Charles Neill <[email protected]> * Update dojo/settings/settings.dist.py Co-authored-by: Charles Neill <[email protected]> * Update dojo/settings/settings.dist.py Co-authored-by: Charles Neill <[email protected]> * Update dojo/tools/jfrog_xray_on_demand_binary_scan/parser.py Co-authored-by: Charles Neill <[email protected]> * Update dojo/tools/jfrog_xray_on_demand_binary_scan/parser.py Co-authored-by: Charles Neill <[email protected]> * Update dojo/tools/jfrog_xray_on_demand_binary_scan/parser.py Co-authored-by: Charles Neill <[email protected]> * Update dojo/tools/jfrog_xray_on_demand_binary_scan/parser.py Co-authored-by: Charles Neill <[email protected]> * Update dojo/tools/jfrog_xray_on_demand_binary_scan/parser.py Co-authored-by: Charles Neill <[email protected]> * Update dojo/tools/jfrog_xray_on_demand_binary_scan/parser.py Co-authored-by: kiblik <[email protected]> * Update dojo/tools/jfrog_xray_on_demand_binary_scan/parser.py Co-authored-by: kiblik <[email protected]> * First round of Improvements * Drop duplicates in component_id and full_path * Process per component * Visual improvements * Use+clean summary in Title, fix dedup, parse version, drop useless functions * Update dojo/tools/jfrog_xray_on_demand_binary_scan/parser.py Co-authored-by: Charles Neill <[email protected]> * Update dojo/tools/jfrog_xray_on_demand_binary_scan/parser.py Co-authored-by: kiblik <[email protected]> * Update dojo/tools/jfrog_xray_on_demand_binary_scan/parser.py Co-authored-by: kiblik <[email protected]> * Update dojo/tools/jfrog_xray_on_demand_binary_scan/parser.py Co-authored-by: kiblik <[email protected]> * Update dojo/tools/jfrog_xray_on_demand_binary_scan/parser.py Co-authored-by: kiblik <[email protected]> * Update dojo/tools/jfrog_xray_on_demand_binary_scan/parser.py Co-authored-by: kiblik <[email protected]> * fix test rename class * Last Improvements and tests * capitalization skills --------- Co-authored-by: Tomas Kubla <[email protected]> Co-authored-by: Charles Neill <[email protected]> Co-authored-by: kiblik <[email protected]> * Update postgres:16.1-alpine Docker digest from 16.1 to 16.1-alpine (docker-compose.yml) (#9089) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Nosey Parker Test Cases * Updated Parser * Bump cryptography from 41.0.5 to 41.0.7 (#9065) Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.5 to 41.0.7. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.5...41.0.7) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * NoseyParker Parser Flake8 compliance * NoseyParker fix for 0.16 * JSON lines fix * Nosey Parker Parser: v0.16 fix * Comma for consistency * Flake8 requirements * Update docs/content/en/integrations/parsers/file/noseyparker.md * Update dojo/tools/noseyparker/parser.py * Update docs/content/en/integrations/parsers/file/noseyparker.md * Removed example JSONL file * Add link to 0.16.0 Release * Spacing --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Greg Anderson <[email protected]> Co-authored-by: Charles Neill <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: manuelsommer <[email protected]> Co-authored-by: Manuel Venega <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Cody Maffucci <[email protected]> Co-authored-by: renejal <[email protected]> Co-authored-by: Tomas Kubla <[email protected]> Co-authored-by: kiblik <[email protected]>

renejal added 7 commits November 16, 2023 15:44

new parser Jfrog Xray on Demand Binary Scan

4770db2

new parser Jfrog Xray on Demand Binary Scan

7c645ac

Merge branch 'feature/parser_jfrog_xray_binary_scan' of https://githu…

c477ed3

…b.com/bancolombia/django-DefectDojo into feature/parser_jfrog_xray_binary_scan

Merge branch 'feature/parser_jfrog_xray_binary_scan' of https://githu…

77572a4

…b.com/bancolombia/django-DefectDojo into feature/parser_jfrog_xray_binary_scan

Merge branch 'feature/parser_jfrog_xray_binary_scan' of https://githu…

4eefc39

…b.com/bancolombia/django-DefectDojo into feature/parser_jfrog_xray_binary_scan

Merge branch 'feature/parser_jfrog_xray_binary_scan' of https://githu…

5364a6a

…b.com/bancolombia/django-DefectDojo into feature/parser_jfrog_xray_binary_scan

Merge branch 'feature/parser_jfrog_xray_binary_scan' of https://githu…

259a808

…b.com/bancolombia/django-DefectDojo into feature/parser_jfrog_xray_binary_scan

github-actions bot added settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR docs unittests parser labels Nov 16, 2023

delete blank line at end of file

0dff403

renejal closed this Nov 17, 2023

renejal reopened this Nov 17, 2023

mtesauro approved these changes Nov 17, 2023

View reviewed changes

blakeaowens reviewed Nov 17, 2023

View reviewed changes

dojo/tools/jfrog_xray_on_demand_binary_scan/parser.py Outdated Show resolved Hide resolved

dojo/tools/jfrog_xray_on_demand_binary_scan/parser.py Outdated Show resolved Hide resolved

renejal and others added 2 commits November 17, 2023 09:16

rename function

83aefa5

More sample reports

7781ef8

cneill requested changes Nov 17, 2023

View reviewed changes

kiblik requested changes Nov 17, 2023

View reviewed changes

renejal and others added 9 commits November 18, 2023 16:20

Update docs/content/en/integrations/parsers/file/jfrog_xray_on_demand…

9591890

…_binary_scan.md Co-authored-by: Charles Neill <[email protected]>

Update docs/content/en/integrations/parsers/file/jfrog_xray_on_demand…

5c10366

…_binary_scan.md Co-authored-by: Charles Neill <[email protected]>

Update docs/content/en/integrations/parsers/file/jfrog_xray_on_demand…

7a139f3

…_binary_scan.md Co-authored-by: Charles Neill <[email protected]>

Update dojo/settings/settings.dist.py

2f01430

Co-authored-by: Charles Neill <[email protected]>

Update dojo/settings/settings.dist.py

3ba1a15

Co-authored-by: Charles Neill <[email protected]>

Update dojo/tools/jfrog_xray_on_demand_binary_scan/parser.py

8b7c29c

Co-authored-by: Charles Neill <[email protected]>

Update dojo/tools/jfrog_xray_on_demand_binary_scan/parser.py

8bd9320

Co-authored-by: Charles Neill <[email protected]>

Update dojo/tools/jfrog_xray_on_demand_binary_scan/parser.py

165084a

Co-authored-by: Charles Neill <[email protected]>

Update dojo/tools/jfrog_xray_on_demand_binary_scan/parser.py

f9419a9

Co-authored-by: Charles Neill <[email protected]>

kiblik and others added 3 commits November 20, 2023 21:44

Use+clean summary in Title, fix dedup, parse version, drop useless fu…

ce10533

…nctions

Update dojo/tools/jfrog_xray_on_demand_binary_scan/parser.py

bcb0ecc

Co-authored-by: Charles Neill <[email protected]>

Update dojo/tools/jfrog_xray_on_demand_binary_scan/parser.py

7e03894

Co-authored-by: kiblik <[email protected]>

renejal and others added 8 commits November 21, 2023 08:10

Update dojo/tools/jfrog_xray_on_demand_binary_scan/parser.py

57c2a83

Co-authored-by: kiblik <[email protected]>

Update dojo/tools/jfrog_xray_on_demand_binary_scan/parser.py

65ab485

Co-authored-by: kiblik <[email protected]>

Update dojo/tools/jfrog_xray_on_demand_binary_scan/parser.py

f49f0d1

Co-authored-by: kiblik <[email protected]>

Update dojo/tools/jfrog_xray_on_demand_binary_scan/parser.py

73a4ba3

Co-authored-by: kiblik <[email protected]>

Merge branch 'feature/parser_jfrog_xray_binary_scan' into jfrog_more_…

26fce7a

…tests

Merge pull request #81 from kiblik/jfrog_more_tests

3c5a58c

JFrog mprovements

fix test rename class

c3347af

Last Improvements and tests

23b3087

Merge pull request #82 from kiblik/jfrog_more_tests

9cb5893

Xray on demand: Last Improvements and tests

renejal requested a review from cneill November 24, 2023 13:05

capitalization skills

ccae048

renejal requested review from kiblik and blakeaowens November 24, 2023 14:04

kiblik approved these changes Nov 24, 2023

View reviewed changes

renejal requested a review from kiblik November 27, 2023 14:52

kiblik approved these changes Nov 27, 2023

View reviewed changes

cneill approved these changes Nov 28, 2023

View reviewed changes

devGregA approved these changes Nov 29, 2023

View reviewed changes

renejal requested a review from kiblik November 29, 2023 20:57

kiblik approved these changes Nov 29, 2023

View reviewed changes

grendel513 approved these changes Nov 30, 2023

View reviewed changes

mtesauro merged commit b42c374 into DefectDojo:dev Dec 2, 2023
118 checks passed

renejal deleted the feature/parser_jfrog_xray_binary_scan branch December 5, 2023 13:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/parser jfrog xray binary scan #9015

Feature/parser jfrog xray binary scan #9015

renejal commented Nov 16, 2023

mtesauro commented Nov 16, 2023

mtesauro left a comment

cneill left a comment

kiblik left a comment

dryrunsecurity bot commented Nov 21, 2023 •

edited

Loading

kiblik commented Nov 22, 2023

Feature/parser jfrog xray binary scan #9015

Feature/parser jfrog xray binary scan #9015

Conversation

renejal commented Nov 16, 2023

mtesauro commented Nov 16, 2023

mtesauro left a comment

Choose a reason for hiding this comment

cneill left a comment

Choose a reason for hiding this comment

kiblik left a comment

Choose a reason for hiding this comment

dryrunsecurity bot commented Nov 21, 2023 • edited Loading

Contextual Security Analysis

kiblik commented Nov 22, 2023

dryrunsecurity bot commented Nov 21, 2023 •

edited

Loading