Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authenticated? Go home from login page #9003

Closed
wants to merge 7 commits into from

Conversation

kiblik
Copy link
Contributor

@kiblik kiblik commented Nov 15, 2023

If a user is already logged in but because of an unknown reason ends up on the login page.
The login page for logged-in users is useless.

Possible reasons:

  • Not the best bookmark
  • Cached autocompletes

@kiblik kiblik force-pushed the logged_in_on_loggin_page branch from 37891e4 to d32f8f6 Compare November 15, 2023 18:08
@kiblik kiblik changed the base branch from dev to bugfix November 15, 2023 18:08
@kiblik kiblik marked this pull request as draft November 15, 2023 18:33
@kiblik
Copy link
Contributor Author

kiblik commented Nov 15, 2023

Ok, I suppose, this might be a nice change but so many integration tests should be fixed. Maybe a bit later.

@Maffooch
Copy link
Contributor

Good change! I am surprised by the number of failing tests...

@kiblik kiblik changed the title Authenticate, go home from login page Authenticated? Go home from login page Nov 28, 2023
DefectDojo release bot and others added 7 commits March 4, 2024 20:59
@kiblik kiblik force-pushed the logged_in_on_loggin_page branch from d32f8f6 to a6cdaec Compare March 8, 2024 17:36
@github-actions github-actions bot added New Migration Adding a new migration file. Take care when merging. docs unittests ui helm conflicts-detected labels Mar 8, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

github-actions bot commented Apr 2, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@Maffooch
Copy link
Contributor

It looks like there has not been any activity here for a while. In order to keep the list of pull requests in a manageable state, we are closing this one for now. If we are making a mistake here, please reopen the pull request, and leave us a note 😄

@Maffooch Maffooch closed this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs helm New Migration Adding a new migration file. Take care when merging. ui unittests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants