Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra path in Engagement endpoint for checklists #7771

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

Maffooch
Copy link
Contributor

@Maffooch Maffooch commented Mar 7, 2023

Add extra path in Engagement endpoint for checklists because there was not a way to get or create those checklists from the api

@github-actions github-actions bot added the apiv2 label Mar 7, 2023
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link
Contributor

@blakeaowens blakeaowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blakeaowens blakeaowens merged commit 50b7b3a into DefectDojo:bugfix Mar 10, 2023
@kiblik
Copy link
Contributor

kiblik commented Jul 4, 2024

@Maffooch, I'm just working on #9751 and I found out that this PR is using the non-existing function get_authorized_engagement_checklists. Can you check it, please?

@Maffooch
Copy link
Contributor Author

Maffooch commented Jul 8, 2024

@kiblik Thanks for the heads up. I found this the other day as well. I believe at the time of implementation, I attempted to add a full endpoint with model viewsets for Engagement Checklists, but then backed up to only add a few new paths to the Engagement viewset. Since the viewset was not actually called anywhere, there was never an error thrown for trying to use the non existent get_authorized_engagement_checklists method.

In a later PR (#10503) I removed the EngagementCheckListViewset viewset that calls the get_authorized_engagement_checklists method. You could do that same in your PR, or just pull in the latest changes from the release when it drops later today

@Maffooch Maffooch deleted the sc-660 branch July 8, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants