Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Burp Scan to use Hashcode Dedupe #11419

Open
wants to merge 2 commits into
base: bugfix
Choose a base branch
from

Conversation

hblankenship
Copy link
Collaborator

[sc-9358]

Update Burp scan to use hashcode deduplication (versus legacy). Fields of relevance are title, file_path, severity, and vuln_id_from_tool.

@github-actions github-actions bot added the settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR label Dec 13, 2024
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@fopina
Copy link
Contributor

fopina commented Dec 17, 2024

Why file_path if this is DAST/endpoint?

Copy link

DryRun Security Summary

The pull request aims to enhance DefectDojo's handling of Burp Scan findings by updating SAML attribute mapping and implementing a specific deduplication algorithm for the Burp Scan parser.

Expand for full summary

Summary:

The code changes in this pull request are focused on improving the handling and integration of findings from the Burp Scan parser in the DefectDojo application. The changes involve updating the saml2_attrib_map_format dictionary to map specific SAML attributes to Django user model fields for the "Burp Scan" parser, and adding a new entry to the DEDUPLICATION_ALGORITHM_PER_PARSER dictionary to specify the deduplication algorithm to be used for the "Burp Scan" parser.

These changes are relevant from an application security perspective, as they suggest that the DefectDojo application is integrating with a SAML-based authentication system and processing findings from the Burp Scan tool, which is a common source of security vulnerability data for web applications. The use of the DEDUPE_ALGO_HASH_CODE algorithm for deduplicating findings can help to ensure that similar findings are properly identified and consolidated, which is an important aspect of effectively managing and addressing security vulnerabilities.

Files Changed:

  • dojo/settings/settings.dist.py: This file contains the Django settings for the DefectDojo application. The changes made in this pull request include:
    1. Adding a new entry to the saml2_attrib_map_format dictionary, which maps specific SAML attributes to Django user model fields for the "Burp Scan" parser.
    2. Adding a new entry to the DEDUPLICATION_ALGORITHM_PER_PARSER dictionary, which specifies the deduplication algorithm to be used for the "Burp Scan" parser as DEDUPE_ALGO_HASH_CODE.

These changes are focused on improving the handling and integration of findings from the Burp Scan parser, which is a common source of security vulnerability data for web applications.

Code Analysis

We ran 9 analyzers against 1 file and 0 analyzers had findings. 9 analyzers had no findings.

View PR in the DryRun Dashboard.

@hblankenship
Copy link
Collaborator Author

Why file_path if this is DAST/endpoint?

Excellent question. I was only paying attention to what items were available/listed in the scanner test files. I updated to remove file_path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants