Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: external image replacement, universal importer docs #11328

Closed
wants to merge 19 commits into from

Conversation

paulOsinski
Copy link
Contributor

@paulOsinski paulOsinski commented Nov 25, 2024

This PR is intended to move externally hosted images into the main repo, along with the following docs updates

Done:

  • Add Universal Importer docs
  • Add Pro Changelog

Still to do before I undraft:

  • Add new screenshots to repo
  • Remove external image links for screenshots

@github-actions github-actions bot added the docs label Nov 25, 2024
Copy link

dryrunsecurity bot commented Nov 25, 2024

DryRun Security Summary

The pull request primarily focuses on updates to the .gitignore file and the GitHub Actions workflow for building and deploying a website to GitHub Pages, which require a thorough review to ensure the exclusion of sensitive information and the absence of potential security vulnerabilities.

Expand for full summary

Summary:

The changes in this pull request are primarily focused on updates to the .gitignore file and the GitHub Actions workflow for building and deploying a website to GitHub Pages. While these changes do not directly introduce any obvious security concerns, it's important to review the overall configuration and ensure that sensitive information or potentially vulnerable files are properly excluded from the version control system and the deployment process.

The changes to the .gitignore file remove the exclusion of the package-lock.json file in the docs/ directory, which could potentially expose information about the project's dependencies. Additionally, it's crucial to review the entire .gitignore file to ensure that it is properly configured to exclude any sensitive or potentially vulnerable files or directories.

The changes to the GitHub Actions workflow improve the reliability and consistency of the build and deployment process, including the use of recursive submodule checkout, the setup of GitHub Pages configuration, and the correct handling of the base URL for the deployed website. These changes do not appear to introduce any direct security vulnerabilities, but it's important to review the entire workflow and associated dependencies to ensure that there are no potential security risks.

Files Changed:

  1. .gitignore: The changes remove the exclusion of the package-lock.json file in the docs/ directory, which could potentially expose information about the project's dependencies. It's important to review the entire .gitignore file to ensure that it is properly configured to exclude any sensitive or potentially vulnerable files or directories.

  2. .github/workflows/gh-pages.yml: The changes in this file are focused on improving the reliability and consistency of the GitHub Pages deployment process, including the use of recursive submodule checkout, the setup of GitHub Pages configuration, and the correct handling of the base URL for the deployed website. These changes do not appear to introduce any direct security vulnerabilities, but it's important to review the entire workflow and associated dependencies to ensure that there are no potential security risks.

Code Analysis

We ran 9 analyzers against 30 files and 0 analyzers had findings. 9 analyzers had no findings.

View PR in the DryRun Dashboard.

Maffooch and others added 17 commits November 25, 2024 17:53
Bumps [boto3](https://github.com/boto/boto3) from 1.35.68 to 1.35.69.
- [Release notes](https://github.com/boto/boto3/releases)
- [Commits](boto/boto3@1.35.68...1.35.69)

---
updated-dependencies:
- dependency-name: boto3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ojo#11333)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…efectDojo#11330)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Ruff: add SIM

* Ruff: fix some SIM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants