-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HCL AppScan on Cloud SAST results parser #11173
Conversation
DryRun Security SummaryThe text indicates that there are no code changes or files provided, so the application security engineer cannot review or summarize any specific code changes, but is ready to provide a security-focused assessment on any future pull requests that contain code changes. Expand for full summarySummary: There are no code changes provided in the input, so I do not have any specific code changes to review or summarize. As an application security engineer, I would typically review any code changes in a pull request to ensure they do not introduce any security vulnerabilities or unintended consequences. Without any code changes to analyze, I cannot provide a meaningful summary. However, I am ready to review any future pull requests that contain code changes and provide my security-focused assessment. Files Changed: There are no files changed in the provided input. Code AnalysisWe ran Riskiness🟢 Risk threshold not exceeded. |
@xpert98 Thanks for the parser contribution. I've kicked off the GH action tests to see how those go but you'll definitely need to fix the ruff linter issues before we'll start reviewing this PR. |
Updates implemented based on the linter results. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
@xpert98 Thanks for fixing the ruff issues. I just re-kicked off the tests - wait till those finish and, assuming they're green, you'll just need to fix the merge conflicts. Nice work so far... 👍 |
Should settings.dist.py be left out of the commit in order to pass the test? |
@mtesauro Any advice on how to proceed? It appears to me like the rest framework unit test failure is unrelated to my parser (but happy to make any adjustments if it is related) |
Hi @xpert98
|
We are narrowing the scope of acceptable enhancements to DefectDojo in preparation for v3. Learn more here:
https://github.com/DefectDojo/django-DefectDojo/blob/master/readme-docs/CONTRIBUTING.md
Description
New parser for HCL AppScan on Cloud SAST results.
Test results
Unit tests (and samples) added. Tests pass.
Documentation
Documentation file added
Checklist
This checklist is for your information.
dev
.dev
.bugfix
branch.Extra information