Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCL AppScan on Cloud SAST results parser #11173

Closed
wants to merge 0 commits into from

Conversation

xpert98
Copy link

@xpert98 xpert98 commented Oct 31, 2024

⚠️ Note on feature completeness ⚠️

We are narrowing the scope of acceptable enhancements to DefectDojo in preparation for v3. Learn more here:
https://github.com/DefectDojo/django-DefectDojo/blob/master/readme-docs/CONTRIBUTING.md

Description
New parser for HCL AppScan on Cloud SAST results.

Test results
Unit tests (and samples) added. Tests pass.

Documentation
Documentation file added

Checklist

This checklist is for your information.

  • Make sure to rebase your PR against the very latest dev.
  • Features/Changes should be submitted against the dev.
  • Bugfixes should be submitted against the bugfix branch.
  • Give a meaningful name to your PR, as it may end up being used in the release notes.
  • Your code is flake8 compliant.
  • Your code is python 3.11 compliant.
  • If this is a new feature and not a bug fix, you've included the proper documentation in the docs at https://github.com/DefectDojo/django-DefectDojo/tree/dev/docs as part of this PR.
  • Model changes must include the necessary migrations in the dojo/db_migrations folder.
  • Add applicable tests to the unit tests.
  • Add the proper label to categorize your PR.

Extra information

@github-actions github-actions bot added settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR docs unittests parser labels Oct 31, 2024
Copy link

dryrunsecurity bot commented Oct 31, 2024

DryRun Security Summary

The text indicates that there are no code changes or files provided, so the application security engineer cannot review or summarize any specific code changes, but is ready to provide a security-focused assessment on any future pull requests that contain code changes.

Expand for full summary

Summary:

There are no code changes provided in the input, so I do not have any specific code changes to review or summarize. As an application security engineer, I would typically review any code changes in a pull request to ensure they do not introduce any security vulnerabilities or unintended consequences. Without any code changes to analyze, I cannot provide a meaningful summary. However, I am ready to review any future pull requests that contain code changes and provide my security-focused assessment.

Files Changed:

There are no files changed in the provided input.

Code Analysis

We ran 9 analyzers against 0 files and 0 analyzers had findings. 9 analyzers had no findings.

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

@manuel-sommer
Copy link
Contributor

#11162

@mtesauro
Copy link
Contributor

mtesauro commented Nov 2, 2024

@xpert98 Thanks for the parser contribution.

I've kicked off the GH action tests to see how those go but you'll definitely need to fix the ruff linter issues before we'll start reviewing this PR.

@xpert98
Copy link
Author

xpert98 commented Nov 3, 2024

Updates implemented based on the linter results.

Copy link
Contributor

github-actions bot commented Nov 4, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@mtesauro
Copy link
Contributor

mtesauro commented Nov 5, 2024

@xpert98 Thanks for fixing the ruff issues.

I just re-kicked off the tests - wait till those finish and, assuming they're green, you'll just need to fix the merge conflicts.

Nice work so far... 👍

@xpert98
Copy link
Author

xpert98 commented Nov 8, 2024

Should settings.dist.py be left out of the commit in order to pass the test?

@xpert98
Copy link
Author

xpert98 commented Nov 15, 2024

@mtesauro Any advice on how to proceed? It appears to me like the rest framework unit test failure is unrelated to my parser (but happy to make any adjustments if it is related)

@kiblik
Copy link
Contributor

kiblik commented Nov 15, 2024

Hi @xpert98

  • Regarding unit test, can you try to rebase (or merge from dev)? It really looks irrelevant but you never know.
  • Regarding settings.dist.py. The edit of this file is correct and it can be performed in PR. But the hash needs to be recalculated with every edit of this file (merge/rebase from dev might require recalculation as well - if the file was edited in the meantime)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflicts-detected docs parser settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR unittests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants