Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 add tenable plugin to reference #11127 #11151

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

manuel-sommer
Copy link
Contributor

@manuel-sommer manuel-sommer commented Oct 29, 2024

closes #11127

Copy link

DryRun Security Summary

The pull request enhances the TenableCSVParser class by adding more reference information to the Finding object and adds a new test case to the TestTenableParser class to ensure the correct extraction of reference information for the "SWEET32" vulnerability.

Expand for full summary

Summary:

The code changes in this pull request are focused on enhancing the functionality of the TenableCSVParser class in the dojo/tools/tenable/csv_format.py file and adding a new test case to the TestTenableParser class in the unittests/tools/test_tenable_parser.py file.

The changes to the TenableCSVParser class are adding additional information to the references field of the Finding object, including the Tenable plugin ID, plugin publication date, and plugin modification date. This additional information can be useful for security analysts and researchers to better understand the context and history of the finding.

The new test case, test_parse_issue_11127, ensures that the TenableParser class correctly extracts the relevant reference information for the "SWEET32" vulnerability (CVE-2016-2183), which is a cryptographic attack that can be used to break encryption when using 64-bit block ciphers, such as Triple-DES. This test case helps to maintain the reliability and accuracy of the Tenable parser implementation.

Files Changed:

  1. dojo/tools/tenable/csv_format.py:

    • The changes in this file are related to the TenableCSVParser class, where additional information is being added to the references field of the Finding object, including the Tenable plugin ID, plugin publication date, and plugin modification date.
    • This additional information can be useful for security analysts and researchers to better understand the context and history of the finding.
  2. unittests/tools/test_tenable_parser.py:

    • The changes in this file are related to the addition of a new test case, test_parse_issue_11127, in the TestTenableParser class.
    • The test case ensures that the TenableParser class correctly extracts the relevant reference information for the "SWEET32" vulnerability (CVE-2016-2183), which is a cryptographic attack that can be used to break encryption when using 64-bit block ciphers, such as Triple-DES.
    • This test case helps to maintain the reliability and accuracy of the Tenable parser implementation.

Code Analysis

We ran 9 analyzers against 2 files and 0 analyzers had findings. 9 analyzers had no findings.

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Maffooch Maffooch merged commit 2bbed9f into DefectDojo:bugfix Nov 1, 2024
72 checks passed
@manuel-sommer manuel-sommer deleted the tenable_11127 branch November 1, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants