Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLA Config: Add new config that does not enforce SLA #11086

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

Maffooch
Copy link
Contributor

It would be nice ship dojo with an SLA config that easily omits SLA configs on a per product basis

[sc-7952]

Copy link

dryrunsecurity bot commented Oct 16, 2024

DryRun Security Summary

The pull request focuses on updating the Service Level Agreement (SLA) configuration and the initialization process for the DefectDojo application, with a focus on enhancing the overall security posture of the application.

Expand for full summary

Summary:

The code changes in this pull request are primarily focused on the application's Service Level Agreement (SLA) configuration and the initialization process for the DefectDojo application. The changes do not introduce any obvious security concerns, but there are a few security-related aspects that should be considered.

The changes to the dojo/fixtures/sla_configurations.json file introduce two new SLA configurations: a "Default SLA Configuration" and a "No SLA Enforced" configuration. While these changes do not directly impact the security of the application, it's important to ensure that the ability to create, modify, or delete SLA configurations is properly restricted to authorized users or roles. Additionally, the SLA configurations should be carefully reviewed to prevent the risk of denial of service due to unrealistic or overly restrictive response times.

The changes to the docker/entrypoint-initializer.sh file focus on the secure initialization and configuration of the DefectDojo application. The script ensures that the admin user is created securely, generates a random password, and configures the JIRA webhook secret and auditlog settings. These security-focused changes help to enhance the overall security posture of the application.

Files Changed:

  1. dojo/fixtures/sla_configurations.json:

    • This file contains the configuration settings for Service Level Agreement (SLA) within the application.
    • The changes introduce two new SLA configurations: a "Default SLA Configuration" and a "No SLA Enforced" configuration.
    • The "Default SLA Configuration" sets the SLA response times and enforces the SLA, while the "No SLA Enforced" configuration sets the SLA response times but does not enforce them.
    • From a security perspective, it's important to ensure that the ability to create, modify, or delete SLA configurations is properly restricted, and that the configurations do not introduce a risk of denial of service.
  2. docker/entrypoint-initializer.sh:

    • This script is responsible for initializing and configuring the DefectDojo application.
    • The changes add a new fixture, sla_configurations, to the list of fixtures that are imported during the initialization process.
    • The script also updates the dojo_system_settings table to set the jira_webhook_secret value, which is a security-sensitive operation.
    • The script ensures that the admin user is created securely, generates a random password, and configures the JIRA webhook secret and auditlog settings, all of which are important security-related aspects.

Code Analysis

We ran 9 analyzers against 2 files and 0 analyzers had findings. 9 analyzers had no findings.

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Maffooch Maffooch merged commit 9a24fe3 into DefectDojo:bugfix Oct 21, 2024
73 checks passed
@Maffooch Maffooch deleted the sla branch October 21, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants