Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump python from 3.11.9-slim-bookworm to 3.12.6-slim-bookworm #10915

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 16, 2024

Bumps python from 3.11.9-slim-bookworm to 3.12.6-slim-bookworm.

Most Recent Ignore Conditions Applied to This Pull Request
Dependency Name Ignore Conditions
python [>= 3.9.a, < 3.10]

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps python from 3.11.9-slim-bookworm to 3.12.6-slim-bookworm.

---
updated-dependencies:
- dependency-name: python
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file docker labels Sep 16, 2024
Copy link

dryrunsecurity bot commented Sep 16, 2024

DryRun Security Summary

The provided code changes update the base Docker images used in the project's Dockerfiles, including upgrading the Python version, managing dependencies, setting environment variables, configuring file permissions, running unit tests, and setting up TLS and metrics-related configurations, all of which are important for ensuring the security and reliability of the application.

Expand for full summary

Summary:

The provided code changes are related to updating the base Docker images used in the project's Dockerfiles. The key changes across the different Dockerfiles include:

  1. Python Version Upgrade: The base Python image has been updated from version 3.11.9 to 3.12.6 in multiple Dockerfiles. This is a minor version upgrade and is generally a positive change, as it may include security fixes and improvements.

  2. Dependency Management: The Dockerfiles install various dependencies required for the Django application, including packages for database connectivity, XML processing, and image manipulation. It's important to ensure these dependencies are kept up-to-date and secure.

  3. Environment Variables: The Dockerfiles set several environment variables, including sensitive information like admin user credentials. Proper management and securing of these variables is crucial to prevent potential security issues.

  4. File Permissions: The Dockerfiles set appropriate file permissions for the application directories and files, which is a good security practice to prevent unauthorized access or modification.

  5. Unit Testing: The Dockerfiles include separate stages for running unit tests, which is a recommended practice for ensuring the application's security and reliability.

  6. TLS Configuration: One of the Dockerfiles sets environment variables related to TLS/SSL configuration, indicating the application is configured to use secure communication. Proper implementation and maintenance of the TLS configuration is important.

  7. Metrics Configuration: One of the Dockerfiles sets environment variables related to exposing metrics, which should be properly secured to prevent unauthorized access.

Overall, the code changes appear to be focused on updating the base Docker images and installing necessary dependencies. From an application security perspective, it's important to thoroughly review the changes, ensure all dependencies are up-to-date and secure, and validate the security of the environment variables, file permissions, and any security-related configurations.

Files Changed:

  1. Dockerfile.nginx-alpine: Updates the base Python image from 3.11.9 to 3.12.6, which is generally a positive change for security.
  2. Dockerfile.django-debian: Updates the base Python image and installs various dependencies required for the Django application. Proper management of these dependencies is crucial.
  3. Dockerfile.integration-tests-debian: Updates the base Python image and installs dependencies for running integration tests, including Chrome and ChromeDriver. Keeping these components up-to-date is important for security.
  4. Dockerfile.django-alpine: Updates the base Python image and follows good security practices, such as user separation, permissions management, and unit testing.
  5. Dockerfile.nginx-debian: Updates the base Python image and sets up the nginx web server configuration, including TLS and metrics-related environment variables, which should be reviewed for security.

Code Analysis

We ran 9 analyzers against 5 files and 0 analyzers had findings. 9 analyzers had no findings.

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes to ensure this isn't merged until we're ready to update to Python 3.12

Prior art at #10808 (review)

Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 7, 2024

Superseded by #11004.

@dependabot dependabot bot closed this Oct 7, 2024
@dependabot dependabot bot deleted the dependabot/docker/dev/python-3.12.6-slim-bookworm branch October 7, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file docker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant