-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(doc): Disable markup.highlight.guessSyntax + enable mermaid #10509
Conversation
Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.
Note 🟢 Risk threshold not exceeded. Change Summary (click to expand)The following is a summary of changes in this pull request made by me, your security buddy 🤖. Note that this summary is auto-generated and not meant to be a definitive list of security issues but rather a helpful summary from a security perspective. Summary: This GitHub pull request introduces several changes to the documentation and configuration of the DefectDojo application, with a focus on improving the integration of various authentication methods, including LDAP, social authentication (Auth0, Google, OKTA, Azure AD, Gitlab, Keycloak, GitHub Enterprise), SAML 2.0, and RemoteUser authentication. The key security-related aspects of these changes are:
Overall, the changes in this pull request focus on improving the authentication and authorization capabilities of the DefectDojo application, which is a positive step for the project's security and usability. However, it is crucial to ensure that the various authentication configurations are properly set up and maintained to prevent potential security vulnerabilities. Files Changed:
Powered by DryRun Security |
c6957db
to
40022ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
I found
mermaid
quite handy during the preparation of documentation for #7311.Unfortunately, when
mermaid
is enabledguessSyntax
has to be disabled otherwise graphs are not rendered (becauseguessSyntax
marksmermaid
snippets aslanguage-fallback
and they are not rendered at all).I added languages to places where they have been probably guessed in the past. Now they do not need to be guessed.