Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: slack address on issue template #10411

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

fcecagno
Copy link
Contributor

Description

Address to Slack in the bug report template doesn't exist anymore, so this PR updates it to the right link.

Copy link

Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.

DryRun Security Status Findings
Server-Side Request Forgery Analyzer 0 findings
IDOR Analyzer 0 findings
Configured Codepaths Analyzer 0 findings
Sensitive Files Analyzer 0 findings
SQL Injection Analyzer 0 findings
Authn/Authz Analyzer 0 findings
Secrets Analyzer 0 findings

Note

🟢 Risk threshold not exceeded.

Change Summary (click to expand)

The following is a summary of changes in this pull request made by me, your security buddy 🤖. Note that this summary is auto-generated and not meant to be a definitive list of security issues but rather a helpful summary from a security perspective.

Summary:

The changes in this GitHub pull request update the link for the OWASP Slack workspace invitation in the .github/ISSUE_TEMPLATE/bug_report.md file. The previous link has been updated to the current OWASP Slack invitation link. This change is relatively minor and does not introduce any significant security concerns.

The bug report template is a common and recommended practice to help users report issues effectively and provide the necessary information for the development team to investigate and resolve the problems. However, it's worth noting that the template does not explicitly mention any security-related information or vulnerabilities. If users were to report security vulnerabilities, it would be important to have a separate security-focused issue template or a clear process for handling such reports, potentially through a responsible disclosure program or a dedicated security contact.

Files Changed:

  • .github/ISSUE_TEMPLATE/bug_report.md: This file is a template for users to report bugs in the DefectDojo application. The changes in this pull request update the link for the OWASP Slack workspace invitation from https://owasp-slack.herokuapp.com/ to https://owasp.org/slack/invite. The file contains a template for users to provide information about the bug, steps to reproduce, expected behavior, deployment method, environment information, logs, sample scan files, and screenshots.

Powered by DryRun Security

@mtesauro
Copy link
Contributor

@fcecagno This is a great change - thanks for noticing and doing the PR but we only take PRs against the dev or bugfix branch. Details are at https://github.com/DefectDojo/django-DefectDojo/blob/master/readme-docs/CONTRIBUTING.md

Please change this PR to the bugfix branch so it can get approved and merged. (besides targeting master, this looks fine)

Thanks!

@fcecagno fcecagno changed the base branch from master to bugfix June 15, 2024 22:31
Copy link
Contributor

@Maffooch Maffooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helm test is failing because this PR targeted master initially. The failure can be disregarded in this case since there is not application code being touched

Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Maffooch Maffooch merged commit f92e5c6 into DefectDojo:bugfix Jun 17, 2024
123 of 124 checks passed
@fcecagno fcecagno deleted the patch-1 branch June 17, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants