Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make endpoint names visible in reports #10230

Merged
merged 3 commits into from
May 20, 2024

Conversation

dogboat
Copy link
Contributor

@dogboat dogboat commented May 20, 2024

Description

This patch adds a class to the endpoint name entry on a report so it can be seen; previously the white text was invisible on the white background, this adds the panel color so it can be seen.

Test results

Before (highlighted for visibility):

Screenshot 2024-05-20 at 10 04 44 AM

After:

Screenshot 2024-05-20 at 9 45 27 AM

[sc-6083]

@github-actions github-actions bot added the ui label May 20, 2024
Copy link

dryrunsecurity bot commented May 20, 2024

Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.

DryRun Security Status Findings
Configured Codepaths Analyzer 0 findings
AppSec Analyzer 0 findings
Authn/Authz Analyzer 0 findings
Sensitive Files Analyzer 0 findings
Secrets Analyzer 0 findings

Note

🟢 Risk threshold not exceeded.

Change Summary (click to expand)

The following is a summary of changes in this pull request made by me, your security buddy 🤖. Note that this summary is auto-generated and not meant to be a definitive list of security issues but rather a helpful summary from a security perspective.

Summary:

The provided code change appears to be an update to the custom_html_report_endpoint_list.html template file, which is used to generate a report for security findings associated with various endpoints. The changes focus on improving the presentation and readability of the security findings report, providing security teams with comprehensive information to understand and address the identified issues.

The key changes include modifications to the CSS class for the panel containing the endpoint information, the display of detailed finding information (such as severity, EPSS score/percentile, status, risk acceptance, discovery date, age, reporter, mitigation details, CWE, and Dojo ID), the use of Markdown rendering for various fields, the ability to display sample HTTP requests and responses, finding images, and finding notes. These enhancements help to make the security findings report more visually appealing, informative, and actionable for security teams.

Files Changed:

  • dojo/templates/dojo/custom_html_report_endpoint_list.html: This file is a template used to generate a report for security findings associated with various endpoints. The changes made in this pull request focus on improving the presentation and readability of the report, providing security teams with more comprehensive information to understand and address the identified issues.

Powered by DryRun Security

@Maffooch Maffooch changed the base branch from dev to bugfix May 20, 2024 14:11
@Maffooch Maffooch changed the base branch from bugfix to dev May 20, 2024 14:12
…me panel on reports so it can be seen (previously white text on white background)
@dogboat dogboat force-pushed the report-endpoint-name-style-fix branch from 0e80bca to 0ecb889 Compare May 20, 2024 14:54
@dogboat dogboat changed the base branch from dev to bugfix May 20, 2024 14:54
DefectDojo and others added 2 commits May 20, 2024 14:55
Signed-off-by: DefectDojo <[email protected]>
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Maffooch Maffooch merged commit ebc199b into DefectDojo:bugfix May 20, 2024
123 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants