fix(filters): prevent crashes when start_date == date.min

dojo/filters.py

@@ -2,7 +2,7 @@
 import decimal
 import logging
 import warnings
-from datetime import datetime, timedelta
+from datetime import date, datetime, timedelta
 
 import pytz
 import six
@@ -184,7 +184,10 @@ def filter(self, qs, value):
             start_date = local_tz.localize(datetime.combine(
                 earliest_finding.date, datetime.min.time())
             )
-            self.start_date = _truncate(start_date - timedelta(days=1))
+            try:
+                self.start_date = _truncate(start_date - timedelta(days=1))
+            except OverflowError:  # this will fail when start_date is date.min
+                self.start_date = date.min
             self.end_date = _truncate(now() + timedelta(days=1))
         try:
             value = int(value)
@@ -772,7 +775,10 @@ def any(self, qs, name):
             start_date = local_tz.localize(datetime.combine(
                 earliest_finding.date, datetime.min.time())
             )
-            self.start_date = _truncate(start_date - timedelta(days=1))
+            try:
+                self.start_date = _truncate(start_date - timedelta(days=1))
+            except OverflowError:  # this will fail when start_date is date.min
+                self.start_date = date.min
             self.end_date = _truncate(now() + timedelta(days=1))
             return qs.all()
 
@@ -840,7 +846,10 @@ def filter(self, qs, value):
             start_date = local_tz.localize(datetime.combine(
                 earliest_finding.date, datetime.min.time())
             )
-            self.start_date = _truncate(start_date - timedelta(days=1))
+            try:
+                self.start_date = _truncate(start_date - timedelta(days=1))
+            except OverflowError:  # this will fail when start_date is date.min
+                self.start_date = date.min
             self.end_date = _truncate(now() + timedelta(days=1))
         try:
             value = int(value)

unittests/scans/generic/generic_bad_date.json

@@ -0,0 +1,16 @@
+{
+    "findings": [
+	{
+            "title": "test title",
+            "description": "Test description",
+            "active": true,
+            "verified": true,
+            "severity": "High",
+            "impact": "Some impact",
+            "date": "0001-01-01",
+            "tags": ["security", "network"],
+            "unique_id_from_tool": "0b5a8a8f-b3b0-4fe9-9b27-87d58631ac03",
+            "vuln_id_from_tool": "TEST_BAD_DATE"
+	}
+    ]
+}

unittests/tools/test_generic_parser.py

@@ -650,3 +650,11 @@ def test_parse_json_invalid_finding(self):
             with self.assertRaisesMessage(ValueError,
                     "Not allowed fields are present: ['invalid_field', 'last_status_update']"):
                 parser.get_findings(file, Test())
+
+    def test_parse_json_bad_date(self):
+        with open("unittests/scans/generic/generic_bad_date.json") as fdesc:
+            parser = GenericParser()
+            findings = parser.get_findings(fdesc, Test())
+            self.assertEqual(1, len(findings))
+            # test the filters
+            self.assertEqual(1, len(Finding.objects.filter(active=True)))