Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruff: add and fix G1 and G2 #10088

Merged
merged 1 commit into from
Jul 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions dojo/finding/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -3386,9 +3386,8 @@ def push_to_jira(request, fid):
)

return JsonResponse({"result": "OK"})
except Exception as e:
logger.exception(e)
logger.error("Error pushing to JIRA: ", exc_info=True)
except Exception:
logger.exception("Error pushing to JIRA")
messages.add_message(
request, messages.ERROR, "Error pushing to JIRA", extra_tags="alert-danger"
)
Expand Down
5 changes: 2 additions & 3 deletions dojo/finding_group/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -194,9 +194,8 @@ def push_to_jira(request, fgid):
extra_tags='alert-danger')

return JsonResponse({'result': 'OK'})
except Exception as e:
logger.exception(e)
logger.error('Error pushing to JIRA: ', exc_info=True)
except Exception:
logger.exception('Error pushing to JIRA')
messages.add_message(
request,
messages.ERROR,
Expand Down
1 change: 1 addition & 0 deletions ruff.toml
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ select = [
"EXE",
"ICN",
"LOG",
"G1", "G2",
"INP",
"SLOT",
"PIE",
Expand Down
Loading