Skip to content

Commit

Permalink
Fix "Overdue" tag still visible with closed issues (#9539)
Browse files Browse the repository at this point in the history
  • Loading branch information
FelixHernandez authored Feb 13, 2024
1 parent 48afd9d commit d91eab7
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion dojo/templates/dojo/engagement.html
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ <h3 class="has-filters">
</div>
</td>
<td> {{ e.target_start }} - {{ e.target_end }}
{% if e.is_overdue %}
{% if e.is_overdue and e.status != 'Completed' %}
<span class="tag-label warning-color">
{{ e.target_end|overdue }} overdue
</span>
Expand Down
2 changes: 1 addition & 1 deletion dojo/templates/dojo/engagements_all.html
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ <h3 class="has-filters">
{% endif %}
<td> {{ e.status }} </td>
<td> {{ e.target_start }} - {{ e.target_end }}
{% if e.is_overdue and e.active %}
{% if e.is_overdue and e.active and e.status != 'Completed' %}
<sup><div class="tag-label warning-color">{{ e.target_end|overdue }} overdue</div></sup>
{% endif %}
</td>
Expand Down
2 changes: 1 addition & 1 deletion dojo/templates/dojo/snippets/engagement_list.html
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ <h4> {% if status == "open" %}Active{% elif status == "paused" %}Paused {% else
</td>
<td class="text-left" class="nowrap">{{ eng.target_start|datediff_time:eng.target_end }}
{% if status == "open" %}
{% if eng.is_overdue %}
{% if eng.is_overdue and eng.status != 'Completed' %}
<sup>
<div class="tag-label warning-color">
{{ eng.target_end|overdue }} overdue
Expand Down

0 comments on commit d91eab7

Please sign in to comment.