Skip to content

Commit

Permalink
Remove useless noqa, be more specific for usefull noqa (#9510)
Browse files Browse the repository at this point in the history
  • Loading branch information
kiblik authored Feb 15, 2024
1 parent c1819a1 commit 89cefc7
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 7 deletions.
2 changes: 1 addition & 1 deletion dojo/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

# This will make sure the app is always imported when
# Django starts so that shared_task will use this app.
from .celery import app as celery_app # noqa
from .celery import app as celery_app # noqa: F401

__version__ = '2.32.0-dev'
__url__ = 'https://github.com/DefectDojo/django-DefectDojo'
Expand Down
8 changes: 4 additions & 4 deletions dojo/apps.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,10 @@ def ready(self):

# Load any signals here that will be ready for runtime
# Importing the signals file is good enough if using the reciever decorator
import dojo.announcement.signals # noqa
import dojo.product.signals # noqa
import dojo.test.signals # noqa
import dojo.sla_config.helpers # noqa
import dojo.announcement.signals # noqa: F401
import dojo.product.signals # noqa: F401
import dojo.test.signals # noqa: F401
import dojo.sla_config.helpers # noqa: F401


def get_model_fields_with_extra(model, extra_fields=()):
Expand Down
3 changes: 1 addition & 2 deletions tests/dedupe_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,12 +95,11 @@ def test_delete_findings(self):
# check that user was redirect back to url where it came from based on return_url
self.assertTrue(driver.current_url.endswith('page=1'))


# --------------------------------------------------------------------------------------------------------
# Same scanner deduplication - Deduplication on engagement
# Test deduplication for Bandit SAST scanner
# --------------------------------------------------------------------------------------------------------
@on_exception_html_source_logger # noqa: E301
@on_exception_html_source_logger
def test_add_path_test_suite(self):
logger.debug("Same scanner deduplication - Deduplication on engagement - static. Creating tests...")
# Create engagement
Expand Down

0 comments on commit 89cefc7

Please sign in to comment.