fix(Qualys parser): wrong handling enable_weakness (#10105)

DefectDojo · Jun 3, 2024 · 5b798a9 · 5b798a9
1 parent f9d74f1
commit 5b798a9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/dojo/tools/qualys_webapp/parser.py b/dojo/tools/qualys_webapp/parser.py
@@ -355,7 +355,7 @@ def get_unique_items(
         if qid in g_qid_list:
             index = g_qid_list.index(qid)
             findings[unique_id] = get_glossary_item(
-                glossary[index], finding, enable_weakness
+                glossary[index], finding, enable_weakness=enable_weakness
             )
     for unique_id, finding in get_unique_vulnerabilities(
         info_gathered, test, True, is_app_report
@@ -364,7 +364,7 @@ def get_unique_items(
         if qid in g_qid_list:
             index = g_qid_list.index(qid)
             finding = get_glossary_item(
-                glossary[index], finding, True, enable_weakness
+                glossary[index], finding, True, enable_weakness=enable_weakness
             )
         if qid in ig_qid_list:
             index = ig_qid_list.index(qid)
@@ -393,15 +393,15 @@ def get_items(
         if qid in g_qid_list:
             index = g_qid_list.index(qid)
             findings[qid] = get_glossary_item(
-                glossary[index], finding, enable_weakness
+                glossary[index], finding, enable_weakness=enable_weakness
             )
     for qid, finding in get_vulnerabilities(
         info_gathered, test, True, is_app_report
     ).items():
         if qid in g_qid_list:
             index = g_qid_list.index(qid)
             finding = get_glossary_item(
-                glossary[index], finding, True, enable_weakness
+                glossary[index], finding, True, enable_weakness=enable_weakness
             )
         if qid in ig_qid_list:
             index = ig_qid_list.index(qid)

diff --git a/unittests/tools/test_qualys_webapp_parser.py b/unittests/tools/test_qualys_webapp_parser.py
@@ -54,6 +54,6 @@ def test_qualys_webapp_parser_info_is_vuln(self):
         for finding in findings:
             for endpoint in finding.unsaved_endpoints:
                 endpoint.clean()
-        # 18 non-info findings, 21 total
-        self.assertEqual(18, len([x for x in findings if x.severity != "Info"]))
+        # 21 non-info findings, 21 total
+        self.assertEqual(21, len([x for x in findings if x.severity != "Info"]))
         self.assertEqual(21, len(findings))