ASFF Parser: Respect active status based on RecordState field (#9567

) * resolve asff parser doing * add unittest to retrigger unittests
DefectDojo · Feb 28, 2024 · 3051466 · 3051466
1 parent 5ee7bb4
commit 3051466
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/dojo/tools/asff/parser.py b/dojo/tools/asff/parser.py
@@ -34,6 +34,10 @@ def get_findings(self, file, test):
             else:
                 mitigation = None
                 references = None
+            if item.get("RecordState") and item.get("RecordState") == "ACTIVE":
+                active = True
+            else:
+                active = False
 
             finding = Finding(
                 title=item.get("Title"),
@@ -42,7 +46,7 @@ def get_findings(self, file, test):
                 mitigation=mitigation,
                 references=references,
                 severity=self.get_severity(item.get("Severity")),
-                active=True,  # TODO: manage attribute 'RecordState'
+                active=active,
                 unique_id_from_tool=item.get("Id"),
             )
 

diff --git a/unittests/tools/test_asff_parser.py b/unittests/tools/test_asff_parser.py
@@ -59,3 +59,4 @@ def test_asff_guardduty(self):
             for index, finding in enumerate(findings):
                 self.common_check_finding(finding, data, index, guarddutydate=True)
             self.assertEqual(finding.unsaved_endpoints[0], Endpoint(host="10.0.0.1"))
+            self.assertTrue(finding.active)