[pure] [lsp] Try to recover unit testing of pure interface #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In general it would be nice if future PRs don't remove important tests without fixing them. |
|
@vycastor , I think that some of the refactoring we need for the server should also fix this; in particular the way state is handling needs to be become a bit more abstract as to allow for example file-less parsing. |
ejgallego
force-pushed
the
inline_test+recover
branch
from
26be259 to
368e29a
Compare
Merged
ejgallego
force-pushed
the
inline_test+recover
branch
2 times, most recently
from
abbaa09 to
b33eb64
Compare
PR Deducteam#289 silently removed important unit tests in the Pure module. We try to recover them, but indeed, they don't work, as it seems the library handling API introduced in Deducteam#289 is lacking in terms of how it can be used. There seem to be many problems with the new system in terms of what a language server needs, in particular regarding assumptions about the underlying file system.
ejgallego
force-pushed
the
inline_test+recover
branch
from
b33eb64 to
eceff9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #289 silently removed important unit tests in the Pure module.
We try to recover them, but indeed, they don't work, as it seems the
library handling API introduced in #289 is lacking in terms of how it
can be used. There seem to be many problems with the new system in
terms of what a language server needs, in particular regarding
assumptions about the underlying file system.
I'm afraid this seems to need significant work.