Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #554 #1095

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Fix #554 #1095

merged 1 commit into from
Apr 25, 2024

Conversation

gabrielhdt
Copy link
Member

Bump sedlex to 3.2 which fixes its issue #96
ocaml-community/sedlex#96.

I'm not sure the problem is fixed though: all I could see is that running

$ lambdapi check tests/OK/natproof.lp --verbose 4

resulted in the same output before and after the commit in this pull request.

Bump sedlex to 3.2 which fixes its issue Deducteam#96
ocaml-community/sedlex#96
@fblanqui
Copy link
Member

For the record, this is related to #549 .

@fblanqui fblanqui requested a review from Alidra April 24, 2024 15:17
@fblanqui
Copy link
Member

We should check that this does not affect IDEs (vscode and emacs) as they use from_string.

@fblanqui
Copy link
Member

@gabrielhdt I was already using sedlex 3.2 on my machine.
@Alidra Note that this affect the PR you are doing on position/green zone.

Copy link
Member

@Alidra Alidra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested with Both Vscode and Emacs and seems to work fine.

@fblanqui
Copy link
Member

Thank you @gabrielhdt and @Alidra !

@fblanqui fblanqui merged commit 5f606fa into Deducteam:master Apr 25, 2024
10 checks passed
@gabrielhdt gabrielhdt deleted the iss554 branch April 28, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants