Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set properly standard emacs package #1090

Merged
merged 9 commits into from
Apr 25, 2024

Conversation

gabrielhdt
Copy link
Member

@gabrielhdt gabrielhdt commented Apr 23, 2024

Update, curate and simplify emacs' mode packaging.

  • removed mentions to Cask
  • setup emacs standard packaging through a tarball
  • remove dune integration (don't install the mode through opam or dune)
  • review manual

Gabriel Hondet added 8 commits April 23, 2024 16:23
;; Compatibility: GNU Emacs 26.1
;; Package-Requires: ((emacs "26.1") (eglot "1.5") (math-symbol-lists "1.2.1") (highlight "20190710.1527"))
;; Compatibility: GNU Emacs 28.1
;; Package-Requires: ((emacs "28.1") (eglot "1.6") (math-symbol-lists "1.2.1") (highlight "20190710.1527"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that mean that it will work with emacs 28.1 only? I am using emacs 27.1 currently.

@fblanqui
Copy link
Member

Just by curiosity: what was Cask for?

@fblanqui
Copy link
Member

Q: Is the emacs mode tested by the CI?

@fblanqui fblanqui merged commit a4bc3a4 into Deducteam:master Apr 25, 2024
10 checks passed
@gabrielhdt gabrielhdt deleted the emacs-mode-revision branch April 28, 2024 12:46
@gabrielhdt
Copy link
Member Author

Just by curiosity: what was Cask for?

It's supposed to make packaging easier. I think it's more cumbersome to have to install cask and set it up rather than bypass it and really stick to Emacs' standards.

Q: Is the emacs mode tested by the CI?

No it's not; I don't really know how to test human interfaces (apart from command line interfaces). It would be really cool though.

@fblanqui
Copy link
Member

For CI, I just want to make sure that it compiles only.

@gabrielhdt
Copy link
Member Author

That should be easy to do, you'd just have to call

$ emacs --batch --eval "(add-to-list  'load-path \"$(pwd)\")" --eval '(byte-compile-file "FILE")'

on each file, assuming the command is called from the directory that contains the files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants