fix parsing error : return commands even when the end of the file contains parsing error #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tains parsing error
…gin of the line to display logs related to missing tokens at the end of the file
|
@fblanqui , Can you check if the behavior described in this PR suites you? |
|
@fblanqui, as discussed earlier today, the modifications in this PR work fine with both Vscode and Emacs. Thus, I believe the PR can be merged. |
|
Thanks Abdelghani! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with Vscode or Emacs, if a Lambdapi file contains parsing errors, the parsing phase should return the commands that have been successfully parsed (this is already the case with the command line Lambdapi).
This PR fixes this issue.
Additionally, this PR changes the way navigating the proofs is done in Vscode with the
navigate until cursor.Instead of stopping the green zone at the beginning of current the line, the green zone is expended to the end of the current command.
Finally, this PR fixes stops the green zone before the
{delimiter (and incidentallybegindelimiter) to avoid that the LSP server answers with subgoals of the next tactic missing the current one as described in issue #1049