Show the Goal panel if it has lost focus #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests with Vscode has been successfully performed. Tests with Emacs still need to be performed to unsure that sending null goals does not break the Emacs client. |
|
@fblanqui, the modifications in this PR have been tested with Emacs and don't seem to have any impact on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Vscode, if the Goal panel looses focus (typically, because user selected another panel) Goals are updated in this panel when the user navigates them in the lp file but he can't see them unless clicking on this panel to bring it in front again.
This PR, gives back focus to the Goals panel to bring it back as soon as the user navigates goals without having to clicking the panel himself.
TODO: