Fix Dependabot/GitHub actions/actions/upload artifact 4 #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fblanqui
merged commit cf607ec
into
Deducteam:dependabot/github_actions/actions/upload-artifact-4
10 checks passed
Alidra
added a commit
that referenced
this pull request
Mar 6, 2024
* Bump actions/upload-artifact from 2 to 4 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 2 to 4. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v2...v4) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * Fix Dependabot/GitHub actions/actions/upload artifact 4 (#1065) * fix/pipeline/vscode : use a dedicated job to generate the vscode extension * feat/pipeline/vscode : use nodejs version 20 instead of 16 --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alidra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading actions/upload-artifact@v2 to v4 breaks the generation the Vscode extension in the pipeline because this new version doesn't allow the artifacts exported by the pipeline to have the same name (previous was to replace existing artifacts).
To fix this, a separate job is dedicated to the generation of the Vscode extension independently from OCaml version which avoids multiple generations.
Besides, the nodejs version has been upgrated to newest version (up to 20)