Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(): 4.0.0-rc2 #2162

Merged
merged 7 commits into from
Nov 1, 2023
Merged

chore(): 4.0.0-rc2 #2162

merged 7 commits into from
Nov 1, 2023

Conversation

canonbrother
Copy link
Contributor

@canonbrother canonbrother commented Oct 11, 2023

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

@netlify
Copy link

netlify bot commented Oct 11, 2023

Deploy Preview for jellyfishsdk ready!

Name Link
🔨 Latest commit 363bfd7
🔍 Latest deploy log https://app.netlify.com/sites/jellyfishsdk/deploys/6541d63e7298b4000872c933
😎 Deploy Preview https://deploy-preview-2162--jellyfishsdk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@canonbrother canonbrother changed the title chore(): 4.0.0 rc1 chore(): 4.0.0-rc1 Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #2162 (363bfd7) into main (bad733d) will increase coverage by 1.27%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2162      +/-   ##
==========================================
+ Coverage   91.82%   93.10%   +1.27%     
==========================================
  Files         369      367       -2     
  Lines       11075    11071       -4     
  Branches     1471     1448      -23     
==========================================
+ Hits        10170    10308     +138     
+ Misses        875      729     -146     
- Partials       30       34       +4     
Files Coverage Δ
...es/testcontainers/src/containers/DeFiDContainer.ts 91.75% <100.00%> (ø)
...tcontainers/src/containers/NativeChainContainer.ts 85.71% <100.00%> (ø)
...ontainers/src/containers/RegTestContainer/index.ts 100.00% <ø> (ø)

... and 64 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Oct 11, 2023

Docker build preview for jellyfish/apps is ready!

Built with commit d2e18ba

  • ghcr.io/birthdayresearch/legacy-api:pr-2162
  • ghcr.io/birthdayresearch/playground-api:pr-2162
  • ghcr.io/birthdayresearch/status-api:pr-2162
  • ghcr.io/birthdayresearch/whale-api:pr-2162

You can also get an immutable image with the commit hash

  • ghcr.io/birthdayresearch/legacy-api:d2e18baf6f8957e6d098b4177c409ba262b8f205
  • ghcr.io/birthdayresearch/playground-api:d2e18baf6f8957e6d098b4177c409ba262b8f205
  • ghcr.io/birthdayresearch/status-api:d2e18baf6f8957e6d098b4177c409ba262b8f205
  • ghcr.io/birthdayresearch/whale-api:d2e18baf6f8957e6d098b4177c409ba262b8f205

@canonbrother canonbrother force-pushed the canonbrother/4.0.0-rc1 branch from c324b03 to 7cbcb87 Compare October 27, 2023 05:11
@canonbrother canonbrother changed the title chore(): 4.0.0-rc1 chore(): 4.0.0-rc2 Oct 27, 2023
const attributes = await testing.rpc.masternode.getGov('ATTRIBUTES')
expect(attributes.ATTRIBUTES['v0/locks/token/abc']).toBeUndefined()
}
// TODO(canonbrother): bug on 4.0.0-rc2, check on 4.0.0-stable later
Copy link
Contributor Author

@canonbrother canonbrother Nov 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

release rc2 for LW dusd-loop first

@canonbrother canonbrother marked this pull request as ready for review November 1, 2023 05:12
@fuxingloh fuxingloh merged commit 762230e into main Nov 1, 2023
31 checks passed
@fuxingloh fuxingloh deleted the canonbrother/4.0.0-rc1 branch November 1, 2023 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants