Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(apps/whale-api): fix test flakiness by using "addressC" to generate "addressB" UTXO #1772

Merged
merged 2 commits into from
Jan 25, 2023

Conversation

fuxingloh
Copy link
Contributor

@fuxingloh fuxingloh commented Sep 22, 2022

What this PR does / why we need it:

As per the title.

Which issue(s) does this PR fixes?:

Fixes part of #1771

@codeclimate
Copy link

codeclimate bot commented Sep 22, 2022

Code Climate has analyzed commit 9ec7859 and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented Sep 22, 2022

Deploy Preview for jellyfishsdk ready!

Name Link
🔨 Latest commit 9ec7859
🔍 Latest deploy log https://app.netlify.com/sites/jellyfishsdk/deploys/63cf8cd68aed62000811dbd7
😎 Deploy Preview https://deploy-preview-1772--jellyfishsdk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Base: 89.43% // Head: 93.35% // Increases project coverage by +3.92% 🎉

Coverage data is based on head (9ec7859) compared to base (e5b6f74).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1772      +/-   ##
==========================================
+ Coverage   89.43%   93.35%   +3.92%     
==========================================
  Files         365      366       +1     
  Lines       10977    10985       +8     
  Branches     1431     1432       +1     
==========================================
+ Hits         9817    10255     +438     
+ Misses       1108      701     -407     
+ Partials       52       29      -23     
Impacted Files Coverage Δ
...pps/whale-api/src/module.health/probe.indicator.ts 37.50% <0.00%> (-62.50%) ⬇️
apps/whale-api/src/module.model/_model.probes.ts 26.66% <0.00%> (-60.00%) ⬇️
apps/whale-api/src/module.defid/defid.probes.ts 27.27% <0.00%> (-59.10%) ⬇️
...ps/whale-api/src/module.api/actuator.controller.ts 62.50% <0.00%> (-37.50%) ⬇️
packages/jellyfish-api-core/src/category/server.ts 71.42% <0.00%> (-28.58%) ⬇️
apps/whale-api/src/module.api/subsidy.ts 66.66% <0.00%> (-25.00%) ⬇️
packages/jellyfish-network/src/Network.ts 75.00% <0.00%> (-12.50%) ⬇️
...rc/module.api/interceptors/response.interceptor.ts 91.66% <0.00%> (-8.34%) ⬇️
...ages/jellyfish-api-core/src/category/masternode.ts 92.00% <0.00%> (-8.00%) ⬇️
...c/module.api/interceptors/exception.interceptor.ts 89.28% <0.00%> (-3.58%) ⬇️
... and 66 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Sep 22, 2022

Docker build preview for jellyfish/apps is ready!

Built with commit 2f2113b

  • ghcr.io/jellyfishsdk/legacy-api:pr-1772
  • ghcr.io/jellyfishsdk/playground-api:pr-1772
  • ghcr.io/jellyfishsdk/status-api:pr-1772
  • ghcr.io/jellyfishsdk/whale-api:pr-1772

You can also get an immutable image with the commit hash

  • ghcr.io/jellyfishsdk/legacy-api:2f2113bd800e58ed0662c033ea17cb46de74412c
  • ghcr.io/jellyfishsdk/playground-api:2f2113bd800e58ed0662c033ea17cb46de74412c
  • ghcr.io/jellyfishsdk/status-api:2f2113bd800e58ed0662c033ea17cb46de74412c
  • ghcr.io/jellyfishsdk/whale-api:2f2113bd800e58ed0662c033ea17cb46de74412c

@fuxingloh fuxingloh force-pushed the fuxingloh/address.controller.e2e.ts branch from 32144c2 to 277193c Compare January 24, 2023 07:23
@fuxingloh fuxingloh force-pushed the fuxingloh/address.controller.e2e.ts branch from 277193c to 9ec7859 Compare January 24, 2023 07:46
@fuxingloh fuxingloh changed the title fix(apps/whale-api): flaky address.controller.e2e.ts chore(apps/whale-api): fix test flakiness by using "addressC" to generate "addressB" UTXO Jan 24, 2023
@github-actions github-actions bot added kind/chore Non feature change and removed kind/fix Fix a bug labels Jan 24, 2023
@fuxingloh fuxingloh marked this pull request as ready for review January 24, 2023 08:21
@fuxingloh fuxingloh merged commit 1f0e961 into main Jan 25, 2023
@fuxingloh fuxingloh deleted the fuxingloh/address.controller.e2e.ts branch January 25, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants