fix(jellyfish-network): add missing devnet case (#1991)

#### What this PR does / why we need it: Fixes missing devnet case #### Additional comments?: Added support for `devnet` in `legacy-api` and `ocean-api-client` packages
DeFiCh · Jan 20, 2023 · e07aad2 · e07aad2
1 parent 8fb4248
commit e07aad2
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 2 deletions.
diff --git a/apps/legacy-api/src/pipes/NetworkValidationPipe.ts b/apps/legacy-api/src/pipes/NetworkValidationPipe.ts
@@ -5,14 +5,15 @@ import {
   PipeTransform
 } from '@nestjs/common'
 
-export type SupportedNetwork = 'mainnet' | 'testnet' | 'regtest'
+export type SupportedNetwork = 'mainnet' | 'testnet' | 'devnet' | 'regtest'
 
 @Injectable()
 export class NetworkValidationPipe implements PipeTransform {
   private static readonly VALID_NETWORKS: Set<undefined | SupportedNetwork> = new Set([
     undefined, // defaults to 'mainnet'
     'mainnet',
     'testnet',
+    'devnet',
     'regtest'
   ])
 

diff --git a/packages/jellyfish-network/__tests__/Network.test.ts b/packages/jellyfish-network/__tests__/Network.test.ts
@@ -17,6 +17,11 @@ describe('getNetwork', () => {
     expect(getNetwork('testnet').bech32.hrp).toStrictEqual('tf')
   })
 
+  it('should get devnet', () => {
+    expect(getNetwork('devnet').name).toStrictEqual('devnet')
+    expect(getNetwork('devnet').bech32.hrp).toStrictEqual('tf')
+  })
+
   it('should get regtest', () => {
     expect(getNetwork('regtest').name).toStrictEqual('regtest')
     expect(getNetwork('regtest').bech32.hrp).toStrictEqual('bcrt')

diff --git a/packages/jellyfish-network/src/Network.ts b/packages/jellyfish-network/src/Network.ts
@@ -44,6 +44,8 @@ export function getNetwork (network: NetworkName): Network {
       return MainNet
     case 'testnet':
       return TestNet
+    case 'devnet':
+      return DevNet
     case 'regtest':
       return RegTest
     default:

diff --git a/packages/ocean-api-client/src/OceanApiClient.ts b/packages/ocean-api-client/src/OceanApiClient.ts
@@ -24,7 +24,7 @@ export interface OceanApiClientOptions {
   /**
    * Network that ocean client is configured to
    */
-  network?: 'mainnet' | 'testnet' | 'regtest' | string
+  network?: 'mainnet' | 'testnet' | 'devnet' | 'regtest' | string
 }
 
 /**
-Original file line number
+Diff line change
@@ Expand Up / @@ -24,7 +24,7 @@ export interface OceanApiClientOptions { @@
       /**
        * Network that ocean client is configured to
        */
-      network?: 'mainnet' | 'testnet' | 'regtest' | string
+      network?: 'mainnet' | 'testnet' | 'devnet' | 'regtest' | string
     }
     /**
@@ Expand Down @@