Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MySqlConnector instead of System.Data.SqlClient #9

Merged
merged 6 commits into from
Jul 20, 2024

Conversation

twerthi
Copy link
Contributor

@twerthi twerthi commented Feb 13, 2024

Checklist

  • I have read the Contributing Guide
  • [] I have checked to ensure this does not introduce an unintended breaking changes
  • I have considered appropriate testing for my change

Description

This PR may introduce breaking changes in that in order to use the MySqlConnector NuGet reference, I had to remove the .NET Framework 1.3 profile. In addition, the if code block

#if MY_SQL_DATA_6_9_5
                var code = exception.ErrorCode;
#else
                var code = exception.Code;
#endif

needed to be removed as the exception object in MySqlConnector did not have a .Code property.

@twerthi
Copy link
Contributor Author

twerthi commented Feb 13, 2024

Addresses #8

Tested against MariaDB 10.6.13 (where the old version still worked) and the latest version where it was failing.

@droyad droyad changed the base branch from main to release/6.0.0 March 15, 2024 06:51
@droyad
Copy link
Member

droyad commented Mar 18, 2024

I've removed the old frameworks from the release/6.0.0 branch, so if you could merge that in to yours we should be good to go.

@twerthi
Copy link
Contributor Author

twerthi commented Mar 18, 2024

A little of a round about way of doing it, but I think we've gotten the PR where you want it.

@droyad droyad changed the title Converting to mysqlconnector Use MySqlConnector instead of System.Data.SqlClient Mar 19, 2024
@droyad droyad enabled auto-merge March 19, 2024 03:19
@droyad droyad disabled auto-merge March 19, 2024 05:23
@droyad droyad merged commit bd35774 into DbUp:release/6.0.0 Jul 20, 2024
2 checks passed
@droyad droyad mentioned this pull request Jul 29, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants