Add support for DropDatabase #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Only target netstandard 2.0 * Removed install of net 2.0 * Moved CI optimisations into just the main project * Fix Readme and template * Build on Ubuntu (DbUp#12) * Build on Ubuntu * Used bash variables * Used re-usable workflow * Specified the branch * Used .github/workflow/ path for workflows * Fix name * Used root workflow folder * passed secret explicitly * fix * Not pass secret * Changed branch
This reverts commit 5997347.
droyad
previously approved these changes
Jul 29, 2024
auto-merge was automatically disabled
July 29, 2024 15:29
Head branch was pushed to by a user without write access
|
@droyad Not sure why the test is failing, I have reordered the methods in the ApprovalFiles, maybe that fixes something |
# Conflicts: # .github/workflows/test-report.yml # src/Tests/ApprovalFiles/NoPublicApiChanges.Run.Net.verified.cs
droyad
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Adds three additional extension methods for
SupportedDatabasesForDropDatabaseallowing MySql to be usedin the same manner as the
DbUp.SqlServerpackage.Method signatures and implementation are mainly taken from
DbUp.SqlServerand the already existentSupportedDatabasesForEnsureDatabaseextension methods.DbUp.SqlServerintroduces an additional alter statement before droppingThere is no equivalent in MySql for this.
The possibility to read lock all databases with
was considered but not implemented as it affects all databases. The drop command will fail fast, if any connection is still present.