fix: git-hash目标导致无变更时仍重新编译

Close #8
DawningW · Apr 22, 2024 · 2e08c88 · 2e08c88
1 parent fd9210f
commit 2e08c88
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 12 deletions.
diff --git a/cmake/git-hash.cmake b/cmake/git-hash.cmake
@@ -15,7 +15,7 @@ endif()
 message(STATUS "Git hash is ${GIT_HASH}")
 
 # generate file git_hash.h
-file(WRITE
-    ${TARGET_DIR}/generated/git_hash.h
-    "#define CRP_GIT_HASH \"${GIT_HASH}\"\n" # MSVC .rc need LF
+file(CONFIGURE
+    OUTPUT ${TARGET_DIR}/generated/git_hash.h
+    CONTENT "#define CRP_GIT_HASH \"${GIT_HASH}\"\n" # MSVC .rc need LF
 )
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
@@ -18,21 +18,13 @@ configure_file(
     @ONLY
 )
 
-add_custom_command(
-    OUTPUT
-        ${CMAKE_CURRENT_BINARY_DIR}/generated/git_hash.h
-        ALL
+add_custom_target(git_hash
     COMMAND
         ${CMAKE_COMMAND} -D TARGET_DIR=${CMAKE_CURRENT_BINARY_DIR} -P ${CMAKE_MODULE_DIR}/git-hash.cmake
     WORKING_DIRECTORY
         ${CoralReefPlayer_SOURCE_DIR}
 )
 
-add_custom_target(git_hash ALL
-    DEPENDS
-        ${CMAKE_CURRENT_BINARY_DIR}/generated/git_hash.h
-)
-
 add_library(${PROJECT_NAME}
     ${CMAKE_CURRENT_BINARY_DIR}/generated/coralreefplayer.h
     dllmain.cpp